Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Chroot denylist pattern too strict #3012

Closed
sbluhm opened this issue Nov 21, 2023 · 4 comments · Fixed by #3055
Closed

UI: Chroot denylist pattern too strict #3012

sbluhm opened this issue Nov 21, 2023 · 4 comments · Fixed by #3055
Assignees
Labels

Comments

@sbluhm
Copy link

sbluhm commented Nov 21, 2023

When trying to deny a build for opensuse-leap-15.5-x86_64 the message Pattern "opensuse-leap-15.5-x86_64" does not match "^[a-z0-9-_*]+$" appears and saving is not possible.

Go to Project --> Packages --> --> Section 3 --> Field Chroot denylist.

Enter opensuse-leap-15.5-x86_64

Click save.

Error message appears.

Expectation: This chroot is accepted as it is also available. I guess the full stop is missing from the inclusion list.

@github-project-automation github-project-automation bot moved this to Needs triage in CPT Kanban Nov 21, 2023
@FrostyX FrostyX moved this from Needs triage to In 3 months in CPT Kanban Nov 29, 2023
@FrostyX FrostyX added the bug label Nov 29, 2023
@xsuchy
Copy link
Member

xsuchy commented Nov 29, 2023

This should be constant defined in some shared module.

@FrostyX FrostyX moved this from In 3 months to In Progress in CPT Kanban Dec 11, 2023
@FrostyX FrostyX self-assigned this Dec 11, 2023
FrostyX added a commit to FrostyX/copr that referenced this issue Dec 12, 2023
@FrostyX
Copy link
Member

FrostyX commented Dec 12, 2023

Thank you for the report @sbluhm.

There are two unrelated issues:

  1. The chroot denylist input doesn't allow . character in the value. That's obviously incorrect and I am fixing it in PR frontend: allow dot and plus characters in chroot denylist #3055
  2. There is currently no opensuse-leap-15.5-x86_64 chroot in Copr, so until that happens, the value won't be valid. However, after the PR is merged and released, opensuse-leap-15.4-x86_64 should work because such chroot exists.

@sbluhm
Copy link
Author

sbluhm commented Dec 13, 2023

FYI, copr still doesn't show this change. I assume it takes a while for it to be in production.

@FrostyX
Copy link
Member

FrostyX commented Dec 13, 2023

That's correct @sbluhm, we do new Copr releases every two or three months.

@nikromen nikromen moved this from In Progress to Done in CPT Kanban Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants