Code Review Conclusion #6
Description
Congratulation, You successfully implemented all the features required in this mini project. I have tried your code and successfully download all the images with labels on it. However, there are several problems I encountered while running your code:
- When I run python main.py, function vision.label_images() raises OSError: cannot open resource. It seems that the program can not find '/Library/Fonts/Arial.ttf' in my computer:
- When I tried to use my own twitter credential, I have to directly edit codes in your files. Actually, we are supposed to provide apis to users so that users can pass their custom key & secret to your module.
- I found out that you didn't consider many error conditions: what if the twitter website doesn't response when we have already downloaded like hundreds tweets and there are still many tweets to download; what if some of the image urls is invalid and cause download error. It's better to add some codes to handle these error conditions.
Anyway, you did a great job. Please feel free to discuss with me any time!