Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio/pod/:hanzi returning audio file for sentence instead of individual word #1

Open
zacbennett opened this issue Jun 6, 2021 · 1 comment

Comments

@zacbennett
Copy link

Hiya!

Great work on this API, it's very well done.
I was playing around with the audio/pod/:hanzi feature and noticed that sometimes the API will respond with a whole sentence instead of just the singular word. Unsure of that's intended or not. Some examples:
https://pinyin-word-api.vercel.app/api/audio/pod/%E8%87%AA%E5%B7%B1
https://pinyin-word-api.vercel.app/api/audio/pod/%E6%AC%A2%E8%BF%8E

@felipemarinho97
Copy link
Owner

Hey @zacbennett , thank you!

This is not intended.. the ChinesePod made some changes in their website so the regex that finds the audio file needs some tweaks.

In these cases, the ChinesePod doesn't have any audio samples. See:
https://www.chinesepod.com/dictionary/%E6%AC%A2%E8%BF%8E
https://www.chinesepod.com/dictionary/%E8%87%AA%E5%B7%B1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants