Bugfix/breaking change (#73)

* use "compatible-release" operator in pipfile
upgrade container-app-conf to 5.x.x

* container-app-conf v5.x.x migration

Author: markusressel

Pipfile

@@ -4,14 +4,14 @@ verify_ssl = true
 name = "pypi"
 
 [packages]
-requests = ">=2.20.0"
+requests = "~=2.20"
 click = "*"
 tabulate = ">=0.8.3"
 PyYAML = "*"
 inflect = "*"
-urllib3 = ">=1.24.2"
-tenacity = ">=5.1.1"
-container-app-conf = ">=4.2.3"
+urllib3 = "~=1.24"
+tenacity = "~=5.1"
+container-app-conf = "~=5.0"
 
 [dev-packages]
 pytest = "*"

Pipfile.lock

@@ -118,7 +118,7 @@ This is going to use the same mechanism to load configuration as the CLI tool, t
 from n26.api import Api
 from n26.config import Config
 
-conf = Config(write_reference=False, validate=False)
+conf = Config(validate=False)
 conf.USERNAME.value = "john.doe@example.com"
 conf.PASSWORD.value = "$upersecret"
 conf.LOGIN_DATA_STORE_PATH.value = None

README.md

@@ -45,7 +45,7 @@ def __init__(self, cfg: Config = None):
         :param cfg: configuration object
         """
         if not cfg:
-            cfg = Config(write_reference=False)
+            cfg = Config()
         self.config = cfg
         self._token_data = {}
 

n26/api.py

@@ -24,9 +24,6 @@ def __new__(cls, *args, **kwargs):
             ]
             kwargs["data_sources"] = data_sources
 
-        if "write_reference" not in kwargs.keys():
-            kwargs["write_reference"] = False
-
         return super(Config, cls).__new__(cls, *args, **kwargs)
 
     USERNAME = StringConfigEntry(

n26/config.py

@@ -40,7 +40,7 @@ def test_init_without_config(self):
 
     def test_init_with_config(self):
         from container_app_conf.source.yaml_source import YamlSource
-        conf = config.Config(singleton=False, write_reference=False, data_sources=[
+        conf = config.Config(singleton=False, data_sources=[
             YamlSource("test_creds", "./tests/")
         ])
         api_client = api.Api(conf)

tests/test_api.py

@@ -116,8 +116,7 @@ class N26TestBase(unittest.TestCase):
         singleton=True,
         data_sources=[
             YamlSource("test_creds", "./tests/")
-        ],
-        write_reference=False
+        ]
     )
 
     # this is the Api client