Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize k-space filling axis in RandomMotion #81

Open
fepegar opened this issue Feb 12, 2020 · 3 comments · May be fixed by #1185
Open

Randomize k-space filling axis in RandomMotion #81

fepegar opened this issue Feb 12, 2020 · 3 comments · May be fixed by #1185
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fepegar
Copy link
Owner

fepegar commented Feb 12, 2020

No description provided.

@fepegar fepegar added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2020
@BerserkerMother
Copy link

hey man. this issue is a bit vague to me. do you mean shuffling the order in which spectrum fill result_spectrum?

@fepegar
Copy link
Owner Author

fepegar commented Feb 14, 2022

The final k-space / spectrum is filled from the others always using the last dimension:

torchio/torchio/transforms/augmentation/intensity/random_motion.py

Lines 271 to 274 in eddd02d

ini = 0
for spectrum, fin in zip(spectra, indices):
result_spectrum[..., ini:fin] = spectrum[..., ini:fin]
ini = fin

It would be nice if this dimension was selected randomly.

@BerserkerMother
Copy link

oh got it. thanks.

@blakedewey blakedewey linked a pull request Jul 7, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize Axes in Random Transforms. Add Random Axis to RandomMotion blakedewey/torchio
2 participants
@fepegar @BerserkerMother