Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Update protobuf & jsonschema dependencies #2814

Open
3 tasks done
mariacarmina opened this issue Nov 10, 2022 · 0 comments
Open
3 tasks done

Feature request: Update protobuf & jsonschema dependencies #2814

mariacarmina opened this issue Nov 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@mariacarmina
Copy link

Prerequisites

  • I checked the documentation and made sure this feature does not already exist.
  • I checked the existing issues to make sure this feature has not already been requested.
  • I have read the code of conduct before creating this issue.

Problem

Importing aea version 1.2.3, some packages are not compatible with eth-brownie module such as jsonschema & protobuf.
The output snippets after the installation of the deps:

[pipenv.exceptions.InstallError]: The conflict is caused by:
[pipenv.exceptions.InstallError]:     aea 1.2.3 depends on jsonschema<5.0.0 and >=4.0.0
[pipenv.exceptions.InstallError]:     eth-brownie 1.19.1 depends on jsonschema==3.2.0
[pipenv.exceptions.InstallError]: 

[pipenv.exceptions.InstallError]: The conflict is caused by:
[pipenv.exceptions.InstallError]:     aea 1.2.3 depends on protobuf<=3.19.4 and >=3.19.0
[pipenv.exceptions.InstallError]:     eth-brownie 1.19.1 depends on protobuf==3.20.1
[pipenv.exceptions.InstallError]: 

Feature / Solution

Extend the range of versions of the dependencies in order to be compatible with brownie module as well. Such as:

jsonschema = "^3.2.0"
protobuf = ">=3.19.4,<4.0.0"

Alternatives

No response

Additional Context

No response

@mariacarmina mariacarmina added the enhancement New feature or request label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant