Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include time information in the input raster format for inference #26

Closed
cholmes opened this issue Oct 22, 2024 · 3 comments · Fixed by #57
Closed

include time information in the input raster format for inference #26

cholmes opened this issue Oct 22, 2024 · 3 comments · Fixed by #57
Assignees
Labels
CLI help wanted Extra attention is needed inference

Comments

@cholmes
Copy link
Member

cholmes commented Oct 22, 2024

Using ftw inference download (when #25 merges) results in a file that loses all time information. If we want to do proper fiboa output and include determination_datetime (which we should, as it's a good best practice), we should use the time stamp of the latter satellite image. So we need to include that in the input file format in some way. It is in the STAC Item, so we just need to grab it and stick it somewhere that we can then include in the inference output and polygonization.

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 30, 2024

@cholmes Why is it the datetime of the latter image? Is it always window B? Or actually the later datetime (assuming window a and b have no particular order)?

@cholmes
Copy link
Member Author

cholmes commented Oct 30, 2024

@cholmes Why is it the datetime of the latter image? Is it always window B? Or actually the later datetime (assuming window a and b have no particular order)?

Hrm, I'm not actually sure if it's a requirement that window a and b enforce an order / make an error. We should probably check that case and either handle it or error out. But yeah, it should be the latter datetime (based on the fact determination_datetime is the last known time that you deem the boundary as accurate)

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 30, 2024

Oh, that makes sense. I can just grab the latter date from STAC then.

There's currently no check on window A before window B temporally, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI help wanted Extra attention is needed inference
Projects
None yet
2 participants