Add Closure to distinct() for Form Elements

[zaidpirwani]

Hello,

I have a form where the repeater input elements can be distinct or not based on state of another input - for now I am returning different arrays based on an if statement - the arrays are SAME except a distint method to one input

I added closure to the distinct code on my local machine and seems to be working for me

I want to ask is this something I can submit as a feature enhancement / fix ??
How to do that - seems I need to fork, make the change and then submit a pull request - am I correct

This would be my first pull request on a public project

MODIFICATION

public function distinct(bool | Closure $condition = true): static
{
    $this->rule(static function (Field $component, mixed $state) {
        return function (string $attribute, mixed $value, Closure $fail) use ($component, $state) {
        // Rest of the code
    },$condition);

    return $this;
}

CanBeValidated.php
ORIGINAL CODE - complete method

public function distinct(): static
{
    $this->rule(static function (Field $component, mixed $state) {
        return function (string $attribute, mixed $value, Closure $fail) use ($component, $state) {
            if (blank($state)) {
                return;
            }

            $repeater = $component->getParentRepeater();

            if (! $repeater) {
                return;
            }

            $repeaterStatePath = $repeater->getStatePath();

            $componentItemStatePath = (string) str($component->getStatePath())
                ->after("{$repeaterStatePath}.")
                ->after('.');

            $repeaterItemKey = (string) str($component->getStatePath())
                ->after("{$repeaterStatePath}.")
                ->beforeLast(".{$componentItemStatePath}");

            $repeaterSiblingState = Arr::except($repeater->getState(), [$repeaterItemKey]);

            if (empty($repeaterSiblingState)) {
                return;
            }

            $validationMessages = $component->getValidationMessages();

            if (is_bool($state)) {
                $isSiblingItemSelected = collect($repeaterSiblingState)
                    ->pluck($componentItemStatePath)
                    ->contains(true);

                if ($state && $isSiblingItemSelected) {
                    $fail(__($validationMessages['distinct.only_one_must_be_selected'] ?? 'filament-forms::validation.distinct.only_one_must_be_selected', ['attribute' => $component->getValidationAttribute()]));

                    return;
                }

                if ($state || $isSiblingItemSelected) {
                    return;
                }

                $fail(__($validationMessages['distinct.must_be_selected'] ?? 'filament-forms::validation.distinct.must_be_selected', ['attribute' => $component->getValidationAttribute()]));

                return;
            }

            if (is_array($state)) {
                $hasSiblingStateIntersections = collect($repeaterSiblingState)
                    ->filter(fn (array $item): bool => filled(array_intersect(data_get($item, $componentItemStatePath, []), $state)))
                    ->isNotEmpty();

                if (! $hasSiblingStateIntersections) {
                    return;
                }

                $fail(__($validationMessages['distinct'] ?? 'validation.distinct', ['attribute' => $component->getValidationAttribute()]));

                return;
            }

            $hasDuplicateSiblingState = collect($repeaterSiblingState)
                ->pluck($componentItemStatePath)
                ->contains($state);

            if (! $hasDuplicateSiblingState) {
                return;
            }

            $fail(__($validationMessages['distinct'] ?? 'validation.distinct', ['attribute' => $component->getValidationAttribute()]));
        };
    });

    return $this;
}