Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding filters in multiple places on a table at once #14956

Open
danharrin opened this issue Dec 1, 2024 · 1 comment
Open

Investigate adding filters in multiple places on a table at once #14956

danharrin opened this issue Dec 1, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@danharrin
Copy link
Member

danharrin commented Dec 1, 2024

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@danharrin danharrin added the enhancement New feature or request label Dec 1, 2024
@danharrin danharrin added this to the v4 milestone Dec 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 1, 2024
@archilex
Copy link
Contributor

archilex commented Dec 3, 2024

This would be a great feature and it can definitely be done. I had a working version of this for Advanced Tables where a dev/user could favorite a filter and it would show up above the table. However, where things got complicated for my plugin (which is focused on the user being able to customize the table), was giving the user an easy UI to allow the filter form to be layed out how they needed/wanted. In a dropdown the filter might be two stacked fields, but as a favorite filter above the table they want it to be side by side. Allowing for both layouts, but also developing a UI to allow a user to personalize the filter layout got complicated quickly.

Additionally, when I did have the filters above, it then felt redundant to the. have the indicator right below it. That's why I ultimately pivoted and went with "Advanced Indicators" that can be clicked to show that filters form. That solved the UI problem since layout wise it just displays the same as the dropdown. On top of that, devs/users can favorite a filter and have the indicator be "sticky".

The other issue I faced with filters above was vertical space, especially with mutli-selects, not to mention on mobile. Again, indicators solved that issue for me, and I even added a limitIndicatorsLabels() method so that it can just show a few indicators if the user selects multiple items.

Anyway, just wanted to share my two cents on what I faced when developing my feature. There's definitely a use case for this and I know Dan can nail the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants
@archilex @danharrin and others