pdpv0: switch from hard delete to soft delete to debug #825
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have encountered some issues around hard-delete. Switch to soft-delete for time being. Introduce more logs around deletion flow. Add a temporary XXXshowReomved=true URL parameter to show soft-deleted entries on in GET /pdp/data-sets/$N Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
BigLep
added
the
team/fs-wg
rvagg
approved these changes
Dec 5, 2025
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
OK, but is the commenting out of the DELETE FROM going to mean you're unlikely to encounter this again? Isn't that a likely primary source of the bug we're trying to figure out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered some issues around hard-delete. Switch to
soft-delete for time being.
Introduce more logs around deletion flow.
Add a temporary XXXshowReomved=true URL parameter to show soft-deleted
entries on in GET /pdp/data-sets/$N
Part of #815