-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependabot commits not deploying. Closes #261 #340
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting from dependabot/dependabot-core#3253 (comment) (Oct 2021):
The Actions team is also working on enabling Actions to fetch Dependabot secrets during Dependabot workloads, which will allow you to fetch secrets again. I'll link to the changelog post when it's shipped.
Have you tried adding FLY_API_TOKEN to Dependabot secrets? I suspect such a fix should solve the problem in a much simpler way.
|
If you look at https://github.com/filecoin-station/spark-evaluate/commits/main/, there's no CI being run on dependabot #main commits. It looks like unfortunately this is also the case for This PR won't work then, unfortunately. I don't see how adding a dependabot secret will fix this either. I think we're back to the drawing board. |
😢 I think the first step is to find out why our CI workflow is not triggered for commits created by Dependabot that were pushed to the |
Is it possible that GHA is smart enough to check if the Dependabot Secrets config provides values for all secrets used by the workflow, and if not, then it does not run the workflow at all? |
If that were the case, then https://github.com/filecoin-station/core-fly/blob/main/.github/workflows/dependabot-deploy-check.yml should have worked as the fix though 🤔 |
But even that action isn't run https://github.com/filecoin-station/core-fly/actions/workflows/dependabot-deploy-check.yml |
Apparently it's because of auto-merge! dependabot/fetch-metadata#111 |
So, we need to configure auto-merge using a personal access token. We can use the bot user https://github.com/orgs/filecoin-station/people/filecoin-station-robot for this. Do you have any concerns, @bajtos? |
Sight. Why are they creating so much friction. 😢
None come to my mind. Let's give it a try! |
Let's see how this goes: filecoin-station/core-fly@d8fb90b When it works after the next update, I'll port that here |
Closes #261