Bug: Can get tabs into "stuck/disabled" state

[coinzdude]

Description

1. Open Files, one tab
   

2. Duplicate tab
   

3. Drag left tab over right tab and drop.

The 2nd tab is now in a "disabled" state.

At this point, the 2nd tab is not draggable

Steps To Reproduce

See Description

There are similar/related drag and drop issues with tabs that can be induced.

For example once induced like above, try dragging a new tab into the tab set and this happens

Requirements

• e.g. Fix crash that occurs when...

Files Version

3.2.0.0

Windows Version

22631.3085

Log File

debug.log

[yaira2]

I'm able to repro this every so often, but only with multiple tries and only if I purposely hover over the other tab for some time.

[verdaderoken]

Mine crashes with this error:

2024-02-28 16:08:19.3110|Error|System.Runtime.InteropServices.COMException (0x80004005)
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at ABI.Microsoft.UI.Xaml.IFrameworkElementMethods.FindName(IObjectReference _obj, String name)
   at Files.App.UserControls.InnerNavigationToolbar.InnerNavigationToolbar_obj1_Bindings.Update_ViewModel_IsDetailsLayout(Boolean obj, Int32 phase)
   at Files.App.UserControls.InnerNavigationToolbar.InnerNavigationToolbar_obj1_Bindings.Update_ViewModel(AddressToolbarViewModel obj, Int32 phase)
   at Files.App.UserControls.InnerNavigationToolbar.InnerNavigationToolbar_obj1_Bindings.InnerNavigationToolbar_obj1_BindingsTracking.DependencyPropertyChanged_ViewModel(DependencyObject sender, DependencyProperty prop)
   at ABI.Microsoft.UI.Xaml.DependencyPropertyChangedCallback.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr dp)
--- End of stack trace from previous location ---
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at ABI.Microsoft.UI.Xaml.IDependencyObjectMethods.SetValue(IObjectReference _obj, DependencyProperty dp, Object value)
   at Files.App.Views.MainPage.MultitaskingControl_CurrentInstanceChanged(Object sender, CurrentInstanceChangedEventArgs e)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()
--- End of stack trace from previous location ---
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at ABI.Windows.ApplicationModel.Core.IUnhandledErrorMethods.Propagate(IObjectReference _obj)
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelperWinUI.<.ctor>b__0_3(Object sender, UnhandledErrorDetectedEventArgs eventArgs)
--- End of stack trace from previous location ---
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelperWinUI.<.ctor>b__0_3(Object sender, UnhandledErrorDetectedEventArgs eventArgs)
   at ABI.System.EventHandler`1.Do_Abi_Invoke[TAbi](Void* thisPtr, IntPtr sender, TAbi args)

[yaira2]

@verdaderoken that seems like a different issue.

[NMBSdtayloe]

This is happening to me as well. After the tabs get into this disabled state, clicking the new tab button causes some strange behavior.

For me getting into the disabled tabs state is most reproducible if I am trying to drop onto tabs that aren't the Home tab. So if you try to move any tab and drop onto a Downloads tab and wait for the Downloads tab to turn transparent, it will get into this state.

Even with the Home tab active and moving it onto another tab like a Desktop tab works. Dragging onto Home tabs always seems to function properly for me.