-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display detailed upload progress in notification #155
Comments
Hi shawnmaten, |
Added to internal tracker: https://filestack.atlassian.net/browse/FS-3356 |
@mtariquekhan I don't have an update on this right now but it's still planned to be fixed. |
Is there any new progress on this issue? |
is there any progress @shawnmaten? |
Hey just a heads up @mhswtf and @mtariquekhan I no longer work at Filestack so I wouldn't know about any internal progress on this. You might try mentioning the most recent committer or sending an inquiry through Support. |
It was intended from the start to have detailed upload progress notifications for individual files.
There are 2 major blockers to enabling this.
The first thing that needs to be solved is this issue in the Java SDK. filestack/filestack-java#51 The base SDK was supposed to provide the necessary progress updates for this, as a stream of progress objects from the upload observable, but that isn't working. And looking at the code now, I did not understand how parallelism was working in RX. So that all needs to be sorted out but I think the idea of the RX interface is fine, it's just not straightforward to have RX be parallel. (I still might be really lacking in RX understanding here.)
The other thing is that the UploadService needs some work. The IntentService won't work with non-blocking code. If we subscribe to an observable for the upload, we won't be blocking, and the service would just quit. So instead of an IntentService we need a base Service or maybe something else. And more recent versions of Android have introduced tougher restrictions to prevent battery draining (there's now a job scheduling system, JobIntentService, other things I've skimmed in press releases) so we should conform to that.
The text was updated successfully, but these errors were encountered: