Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler gives no warning if a listed module is not found (e.g. a typo in the module name) #1100

Open
edwardpeters opened this issue Sep 7, 2023 · 0 comments
Labels
task Task level project item

Comments

@edwardpeters
Copy link

edwardpeters commented Sep 7, 2023

Describe the bug
If you have a module listed in morphir.json, but no actual implementation, then no error is thrown and the build appears to pass.

To Reproduce
Steps to reproduce the behavior:
morphir.json:

{
    "name": "Scratch",
    "sourceDirectory": "src",
    "exposedModules": [
        "ExampleModule"
    ]
}

ExampleModule.elm:

module ScratchWithTypo.ExampleModule exposing (..)

typeErrorTest : Bool -> String
typeErrorTest x = True     

Compiling (with either make or make -f) appears to succeed, though nothing is added to morphir-ir.json).

Expected behavior
Some error or at least very loud warning should be given for the missing file.

Adding to the confusion, some errors are thrown from the referenced file - for instance, mismatched paranthesis in the file still gives an error

Desktop (please complete the following information):

  • OS: OSX
  • Browser:2.89.0 Unused
  • Version :

Additional context
Add any other context about the problem here.

@edwardpeters edwardpeters added the task Task level project item label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task level project item
Projects
None yet
Development

No branches or pull requests

1 participant