Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qgis2fds Verification #55

Closed
johodges opened this issue Jul 10, 2023 · 2 comments
Closed

Qgis2fds Verification #55

johodges opened this issue Jul 10, 2023 · 2 comments

Comments

@johodges
Copy link
Collaborator

I have been working through the qgis2fds verification with the updates discussed in #53. Unfortunately, the current master qgis2fds and master qgisfds.verification repositories do not reproduce the reference inputs for each case. I have attached a few slides comparing the current reference files included in the repo, the files generated using the two master branches, and the files generated using #53 and firetools/qgis2fds.verification#1. It looks to me like the files generated with the linked PRs are similar enough to the versions of the files in the repo. The differences in DEM look primarily due to different layer maps and resolution used in generating the verification cases. However, these do not align between the current reference files and the current master branch either. Happy to discuss if needed, just let me know.

qgis2fds_verification.pptx

@rmcdermo
Copy link
Contributor

Thanks, Jonathan. I am working through trying to make a small case with your latest repo to see if the bingeom generated by qgis2fds aligned with the FDS mesh in Smokeview. I'm being plagued by the DEM server timing out on me...

Perhaps tomorrow, if you have time, we can try to assess the state of things. Thanks

@johodges
Copy link
Collaborator Author

johodges commented Aug 7, 2023

Closing this out now that we have a working verification within github actions.

@johodges johodges closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants