Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Shorten session length #14

Open
2 of 4 tasks
fivetran-reneeli opened this issue Sep 20, 2023 · 0 comments
Open
2 of 4 tasks

[Feature] Shorten session length #14

fivetran-reneeli opened this issue Sep 20, 2023 · 0 comments
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-reneeli
Copy link
Collaborator

fivetran-reneeli commented Sep 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

A customer ran into an issue with extremely long session lengths which skew aggregations.

After a certain time, the session should be timed out. Perhaps we can create a filter on session lengths via leveraging a variable for session max duration, and have the default be 1440 minutes (1 day). For sessions longer than the limit we can consider setting it to null

The change will take place in amplitude_sessions, where the session length gets calculated.

Additions: session length variable, and a decision log explaining the default

Relevant error log or model output

No response

Expected behavior

Remove tail-end edge cases of session lengths

dbt Project configurations

n/a

Package versions

n/a

What database are you using dbt with?

bigquery

dbt Version

1.6

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-reneeli fivetran-reneeli added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 20, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement and removed enhancement New feature or request labels Sep 22, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title [Bug] Shorten session length [Feature] Shorten session length Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants