Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into Cadabra repo / make it the official Docker container #2

Open
kpeeters opened this issue Aug 2, 2024 · 2 comments
Open

Comments

@kpeeters
Copy link

kpeeters commented Aug 2, 2024

I would be happy to merge this into the Cadabra repo to make it the official container distribution. That would also make it easier to update it automatically when a new version is released, and I am happy to upload it as an official Docker image for x86_64 and arm64.

I think there are various improvements you can make to reduce the size, e.g. dropping gtk libraries and so on (which you do not need if you only want the Jupyter kernel).

There are various unofficial cadabra2 docker files floating around on dockerhub, and it would be good for newcomers to streamline that a bit.

@fjebaker
Copy link
Owner

fjebaker commented Aug 9, 2024

Hi @kpeeters sounds very good! Let's do it!

What's the best way to approach this? Should I open a PR on the Cadabra repo with the Dockerfile and then we can iterate in the PR branch to get the size down for the Jupyter version? Or would you prefer to work in this repo until it's ready?

@kpeeters
Copy link
Author

kpeeters commented Aug 9, 2024

I have already started adding this to the devel branch of the cadabra2 repo. It's in the docker folder. There is still something not quite right with paths on that one, but I am behind a very slow internet connection at the moment so testing/fixing is a bit of a pain.

I have also added github actions to build the docker image on amd64 and aarch64, in .github/workflow/. This works and builds new images automatically on every push, but it needs some tagging of the resulting images with the cadabra version number before I can enable uploading to dockerhub.

If you want to propose changes, please open a PR against this devel branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants