feat: add EIP-4844 support #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
force-pushed
the
zeke/eip4844
branch
2 times, most recently
from
72fa68a to
47367a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
This PR adds support for eip4844 transactions. eip4844 transactions can be specified with a new
--tx-typecli argument. By default, it will send eip1559 transactions.Adding blob transactions doesn't fit cleanly into the current default scenario due to the nonce gap restrictions on eip4844 transactions: eip4844 transactions are only accepted if they're gapless, meaning the previous nonce of the transaction (
tx.nonce -1) must either be in the pool or match the on chain nonce of the sender. Due to the fact we send a batch of transactions all at once by spawning tokio tasks, we can guarantee they hit the pool in the correct order.To get around this you can set
--num-txs 1. Not sure of a good work around without a bigger refactor.PR Checklist