From 6ba1b5d71591567a7e7cab1b5085e969a0f95ff1 Mon Sep 17 00:00:00 2001 From: Justin Traglia Date: Wed, 25 Sep 2024 16:14:49 -0500 Subject: [PATCH] Try to fix linters --- .github/workflows/checks.yml | 4 ++-- services/api/optimistic_test.go | 5 +++-- services/api/types_test.go | 2 ++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 60111802..8919f975 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -47,10 +47,10 @@ jobs: uses: actions/checkout@v3 - name: Install gofumpt - run: go install mvdan.cc/gofumpt@v0.4.0 + run: go install mvdan.cc/gofumpt@latest - name: Install staticcheck - run: go install honnef.co/go/tools/cmd/staticcheck@v0.4.6 + run: go install honnef.co/go/tools/cmd/staticcheck@latest - name: Install golangci-lint run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.0 diff --git a/services/api/optimistic_test.go b/services/api/optimistic_test.go index fbd4509c..f7bb03fd 100644 --- a/services/api/optimistic_test.go +++ b/services/api/optimistic_test.go @@ -3,6 +3,7 @@ package api import ( "context" "encoding/json" + "errors" "fmt" "math/big" "net/http" @@ -166,7 +167,7 @@ func TestSimulateBlock(t *testing.T) { { description: "block_already_known_capella", version: spec.DataVersionCapella, - simulationError: fmt.Errorf(ErrBlockAlreadyKnown), //nolint:goerr113 + simulationError: errors.New(ErrBlockAlreadyKnown), }, { description: "missing_trie_node_capella", @@ -186,7 +187,7 @@ func TestSimulateBlock(t *testing.T) { { description: "block_already_known_deneb", version: spec.DataVersionDeneb, - simulationError: fmt.Errorf(ErrBlockAlreadyKnown), //nolint:goerr113 + simulationError: errors.New(ErrBlockAlreadyKnown), }, { description: "missing_trie_node_deneb", diff --git a/services/api/types_test.go b/services/api/types_test.go index 95b5f353..dc705ade 100644 --- a/services/api/types_test.go +++ b/services/api/types_test.go @@ -70,6 +70,7 @@ func TestBuilderBlockRequestToSignedBuilderBid(t *testing.T) { }, }, }, + //nolint:dupl { name: "Deneb", reqPayload: &common.VersionedSubmitBlockRequest{ @@ -115,6 +116,7 @@ func TestBuilderBlockRequestToSignedBuilderBid(t *testing.T) { }, }, }, + //nolint:dupl { name: "Electra", reqPayload: &common.VersionedSubmitBlockRequest{