From 1aa7e47399e14d61d5aeba752723a29bcdff5d31 Mon Sep 17 00:00:00 2001 From: avalonche Date: Thu, 16 May 2024 14:58:02 +1000 Subject: [PATCH] Add builder demotion metrics --- metrics/metrics.go | 15 +++++++++++++++ services/api/service.go | 8 ++++++++ 2 files changed, 23 insertions(+) diff --git a/metrics/metrics.go b/metrics/metrics.go index c8b791ae..c7ec13b6 100644 --- a/metrics/metrics.go +++ b/metrics/metrics.go @@ -22,6 +22,8 @@ var ( GetPayloadLatencyHistogram otelapi.Float64Histogram PublishBlockLatencyHistogram otelapi.Float64Histogram + BuilderDemotionCount otelapi.Int64Counter + latencyBoundaries = otelapi.WithExplicitBucketBoundaries(func() []float64 { base := math.Exp(math.Log(12.0) / 15.0) res := make([]float64, 0, 31) @@ -37,6 +39,7 @@ func Setup(ctx context.Context) error { setupMeter, // must come first setupGetPayloadLatency, setupPublishBlockLatency, + setupBuilderDemotionCount, } { if err := setup(ctx); err != nil { return err @@ -98,3 +101,15 @@ func setupPublishBlockLatency(ctx context.Context) error { } return nil } + +func setupBuilderDemotionCount(ctx context.Context) error { + counter, err := meter.Int64Counter( + "builder_demotion_count", + otelapi.WithDescription("number of times a builder has been demoted"), + ) + BuilderDemotionCount = counter + if err != nil { + return err + } + return nil +} diff --git a/services/api/service.go b/services/api/service.go index 4f848318..192e3fd2 100644 --- a/services/api/service.go +++ b/services/api/service.go @@ -458,6 +458,9 @@ func (api *RelayAPI) StartServer() (err error) { // start block-builder API specific things if api.opts.BlockBuilderAPI { + // Initialize metrics + metrics.BuilderDemotionCount.Add(context.Background(), 0) + // Get current proposer duties blocking before starting, to have them ready api.updateProposerDuties(syncStatus.HeadSlot) @@ -600,6 +603,11 @@ func (api *RelayAPI) simulateBlock(ctx context.Context, opts blockSimOptions) (r } func (api *RelayAPI) demoteBuilder(pubkey string, req *common.VersionedSubmitBlockRequest, simError error) { + metrics.BuilderDemotionCount.Add( + context.Background(), + 1, + ) + builderEntry, ok := api.blockBuildersCache[pubkey] if !ok { api.log.Warnf("builder %v not in the builder cache", pubkey)