fix failing htmlproofer

- replace old luce scholars link

- corrects failure for link rel=canonical on new pages

Author: billbrod

.github/workflows/jekyll-gh-pages.yml

@@ -42,10 +42,10 @@ jobs:
       - name: Check html
         uses: chabad360/htmlproofer@master
         with:
-          directory: "./_site"
           # The directory to scan
-          arguments: --no-enforce-https --allow_hash_href --ignore-missing-alt --assume_extension - ./_site --ignore-urls '/http:\/\/www.hluce.org/' --ignore-files '/.+\/assets\/.+/'
-          # The arguments to pass to HTMLProofer
+          directory: "./_site"
+          # The arguments to pass to HTMLProofer. swap-urls is because of this issue: https://github.com/gjtorikian/html-proofer/issues/170 and basically turns all absolute links from our site that point to our site into relative
+          arguments: --no-enforce-https --allow_hash_href --ignore-missing-alt --assume_extension - ./_site --ignore-files '/.+\/assets\/.+/'  --swap-urls "https?\:\/\/(localhost\:4000|neurorse\.flatironinstitute\.org):"
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v2
 

_config.yml

@@ -22,7 +22,7 @@ source: site
 title: NeuroRSE
 description: >- # this means to ignore newlines until "baseurl:"
 baseurl: ""
-url: "https://neurorse.flatironinstitute.org/" # the base hostname & protocol for your site, e.g. http://example.com
+url: "https://neurorse.flatironinstitute.org" # the base hostname & protocol for your site, e.g. http://example.com
 
 # Build settings
 plugins:

site/_people/broderick.md

@@ -5,4 +5,4 @@ external_url: https://wfbroderick.com
 picture: /assets/billy.jpg
 job: Associate Research Scientist, CCN
 ---
-Billy Broderick received his Ph.D. from NYU's Center for Neural Science, where he was advised by Eero Simoncelli and Jon Winawer. During his Ph.D., he studied how vision changes across the visual field using fMRI, psychophysics, and computational models. Before that, he worked as a research assistant at Duke University, spent a year at South China Normal University in Guangzhou, China as a [Luce Scholar](http://www.hluce.org/lsprogram.aspx), and got his B.A. in neuroscience and mathematics at Oberlin College
+Billy Broderick received his Ph.D. from NYU's Center for Neural Science, where he was advised by Eero Simoncelli and Jon Winawer. During his Ph.D., he studied how vision changes across the visual field using fMRI, psychophysics, and computational models. Before that, he worked as a research assistant at Duke University, spent a year at South China Normal University in Guangzhou, China as a [Luce Scholar](https://lucescholars.org/), and got his B.A. in neuroscience and mathematics at Oberlin College