From 0170ca7630482d8f878db4049efb30935fe29af5 Mon Sep 17 00:00:00 2001 From: Sharon Katz Date: Mon, 23 Oct 2023 18:32:20 -0400 Subject: [PATCH] tidy --- orbit/pkg/table/extension_darwin_amd64.go | 8 +------- orbit/pkg/table/extension_darwin_arm64.go | 7 ++----- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/orbit/pkg/table/extension_darwin_amd64.go b/orbit/pkg/table/extension_darwin_amd64.go index 89c0ca1607d0..0c627df30931 100644 --- a/orbit/pkg/table/extension_darwin_amd64.go +++ b/orbit/pkg/table/extension_darwin_amd64.go @@ -27,8 +27,7 @@ import ( "github.com/kolide/launcher/pkg/osquery/tables/profiles" "github.com/kolide/launcher/pkg/osquery/tables/pwpolicy" - // TODO: Need coding/other - //"github.com/kolide/launcher/pkg/osquery/tables/munki" + // TODO: This Kolide table requires more complicated coding //"github.com/kolide/launcher/pkg/osquery/tables/osquery_user_exec_table" "github.com/macadmins/osquery-extension/tables/filevaultusers" @@ -80,10 +79,5 @@ func PlatformTables() []osquery.OsqueryPlugin { pwpolicy.TablePlugin(kolideLogger), airport.TablePlugin(kolideLogger), apple_silicon_security_policy.TablePlugin(kolideLogger), - - // TODO: Need coding/other - // munki.MunkiReport(logger log.Logger), // TODO: compare with the existing munki table. Maybe no need for this. - // osquery_user_exec_table.TablePlugin(logger log.Logger, tablename string, osqueryd string,osqueryQuery string, columns []table.ColumnDefinition,), // add params - } } diff --git a/orbit/pkg/table/extension_darwin_arm64.go b/orbit/pkg/table/extension_darwin_arm64.go index be096a50f718..0b95f759ae88 100644 --- a/orbit/pkg/table/extension_darwin_arm64.go +++ b/orbit/pkg/table/extension_darwin_arm64.go @@ -31,8 +31,7 @@ import ( // ARM64 Kolide tables appicons "github.com/kolide/launcher/pkg/osquery/tables/app-icons" - // TODO: Need coding/other - //"github.com/kolide/launcher/pkg/osquery/tables/munki" + // TODO: This Kolide table requires more complicated coding //"github.com/kolide/launcher/pkg/osquery/tables/osquery_user_exec_table" "github.com/macadmins/osquery-extension/tables/filevaultusers" @@ -89,9 +88,7 @@ func PlatformTables() []osquery.OsqueryPlugin { macos_software_update.MacOSUpdate(), appicons.AppIcons(), - // TODO: Need coding/other - // munki.MunkiReport(logger log.Logger), // TODO: compare with the existing munki table. Maybe no need for this. + // TODO: This Kolide table requires more complicated coding // osquery_user_exec_table.TablePlugin(logger log.Logger, tablename string, osqueryd string,osqueryQuery string, columns []table.ColumnDefinition,), // add params - } }