Msp dashboard: Update error handling in software-related actions (#23065)

For: fleetdm/confidential#8473

Changes:
- Updated the cloud error components message
- Updated the upload-software action to log errors about failed requests
to the Fleet API
- Updated the edit-software action to log errors about failed requests
to the Fleet API, and to delete temporary files when requests fail.
- Updated the software page to clear cloud errors when modals are
closed.

Author: eashaw

ee/bulk-operations-dashboard/api/controllers/software/edit-software.js

@@ -160,9 +160,15 @@ module.exports = {
                 };
               },
             })
-          .intercept((error)=>{
+          .intercept(async (error)=>{
             // Note: with this current behavior, all errors from this upload are currently swallowed and a softwareUploadFailed response is returned.
             // FUTURE: Test to make sure that uploading duplicate software to a team results in a 409 response.
+            // Before handline errors, decide what to do about the file uploaded to s3, if this is undeployed software, we'll leave it alone, but if this was a temporary file created to transfer it between teams on the Fleet instance, we'll delete the file.
+            if(!software.id) {// If the software does not have an ID, it not stored in the app's database/s3 bucket, so we can safely delete the file in s3.
+              await sails.rm(sails.config.uploads.prefixForFileDeletion+softwareFd);
+            }
+            // Log a warning containing an error
+            sails.log.warn(`When attempting to upload a software installer, an unexpected error occurred communicating with the Fleet API, ${require('util').inspect(error, {depth: 0})}`);
             return {'softwareUploadFailed': error};
           });
           // console.timeEnd(`transfering ${software.name} to fleet instance for team id ${team}`);
@@ -229,9 +235,15 @@ module.exports = {
                 };
               },
             })
-            .intercept((error)=>{
+            .intercept(async (error)=>{
               // Note: with this current behavior, all errors from this upload are currently swallowed and a softwareUploadFailed response is returned.
               // FUTURE: Test to make sure that uploading duplicate software to a team results in a 409 response.
+              // Before handling errors, decide what to do about the file uploaded to s3, if this is undeployed software, we'll leave it alone, but if this was a temporary file created to transfer it between teams on the Fleet instance, we'll delete the file.
+              if(!software.id) {
+                await sails.rm(sails.config.uploads.prefixForFileDeletion+softwareFd);
+              }
+              // Log a warning containing an error
+              sails.log.warn(`When attempting to upload a software installer, an unexpected error occurred communicating with the Fleet API, ${require('util').inspect(error, {depth: 0})}`);
               return {'softwareUploadFailed': error};
             });
             // console.timeEnd(`transfering ${software.name} to fleet instance for team id ${teamApid}`);

ee/bulk-operations-dashboard/api/controllers/software/upload-software.js

@@ -33,6 +33,10 @@ module.exports = {
       statusCode: 409,
     },
 
+    softwareUploadFailed: {
+      description:'An unexpected error occurred communicating with the Fleet API'
+    }
+
   },
 
 
@@ -51,8 +55,8 @@ module.exports = {
       };
       await UndeployedSoftware.create(newSoftwareInfo);
     } else {
+      uploadedSoftware = await sails.uploadOne(newSoftware, {bucket: sails.config.uploads.bucketWithPostfix});
       for(let teamApid of teams) {
-        uploadedSoftware = await sails.uploadOne(newSoftware, {bucket: sails.config.uploads.bucketWithPostfix});
         var WritableStream = require('stream').Writable;
         await sails.cp(uploadedSoftware.fd, {bucket: sails.config.uploads.bucketWithPostfix}, {
           adapter: ()=>{
@@ -96,8 +100,14 @@ module.exports = {
             };
           }
         })
-        .intercept({response: {status: 409}}, (error)=>{
+        .intercept({response: {status: 409}}, async (error)=>{
+          await sails.rm(sails.config.uploads.prefixForFileDeletion+uploadedSoftware.fd);
           return {'softwareAlreadyExistsOnThisTeam': error};
+        })
+        .intercept({name: 'AxiosError'}, async (error)=>{
+          await sails.rm(sails.config.uploads.prefixForFileDeletion+uploadedSoftware.fd);
+          sails.log.warn(`When attempting to upload a software installer, an unexpected error occurred communicating with the Fleet API, ${require('util').inspect(error, {depth: 0})}`);
+          return {'softwareUploadFailed': error};
         });
       }
       // Remove the file from the s3 bucket after it has been sent to the Fleet server.

ee/bulk-operations-dashboard/assets/js/components/cloud-error.component.js

@@ -43,7 +43,7 @@ parasails.registerComponent('cloud-error', {
   //  ╩ ╩ ╩ ╩ ╩╩═╝
   template: `
   <div>
-    <p :class="{ 'm-0': beWithoutMargins }" class="text-danger"><slot name="default">An error occured while processing your request. Please check your information and try again, or <a href="/contact">contact support</a> if the error persists.</slot></p>
+    <p :class="{ 'm-0': beWithoutMargins }" class="text-danger"><slot name="default">An unexpected error occurred communicating with the Fleet API</slot></p>
   </div>
   `,
 

ee/bulk-operations-dashboard/assets/js/pages/software/software.page.js

@@ -95,6 +95,7 @@ parasails.registerPage('software', {
       this.modal = '';
       this.formErrors = {};
       this.formData = {};
+      this.cloudError = '';
       this.showAdvancedOptions = false;
       await this.forceRender();
     },