From 281b5ffaf7cea79f9cbb485ac153df3663b9d00f Mon Sep 17 00:00:00 2001 From: Noah Talerman <47070608+noahtalerman@users.noreply.github.com> Date: Fri, 15 Mar 2024 19:02:15 -0400 Subject: [PATCH] Rachael is API design DRI (#17630) - Move "API design" DRI from "Product groups" page to DRIs table --- handbook/company/communications.md | 1 + handbook/company/product-groups.md | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/handbook/company/communications.md b/handbook/company/communications.md index 047f1aa7472a..3fdc72b5ebca 100644 --- a/handbook/company/communications.md +++ b/handbook/company/communications.md @@ -21,6 +21,7 @@ We track competitors' capabilities and adjacent (or commonly integrated) product | Engineering output and architecture | [Luke Heath](https://www.linkedin.com/in/lukeheath/) _([@lukeheath](https://github.com/lukeheath))_ | | Structure and intentionallity of the [Docs](https://fleetdm.com/docs/get-started/why-fleet)| [Mike Thomas](https://www.linkedin.com/in/mike-thomas-52277938) _([@mike-j-thomas](https://github.com/mike-j-thomas))_ | | Design and content of the [Docs](https://fleetdm.com/docs/get-started/why-fleet) | [Rachael Shaw](https://www.linkedin.com/in/rachaelcshaw/) _([@rachaelshaw](https://github.com/rachaelshaw))_ | +| API design | [Rachael Shaw](https://www.linkedin.com/in/rachaelcshaw/) _([@rachaelshaw](https://github.com/rachaelshaw))_ | ### Docs diff --git a/handbook/company/product-groups.md b/handbook/company/product-groups.md index 265b20af8942..506831d76976 100644 --- a/handbook/company/product-groups.md +++ b/handbook/company/product-groups.md @@ -88,9 +88,7 @@ For product changes that cause breaking API or configuration changes or major im That all happens prior to work getting prioritized for the change. #### API changes -To maintain consistency, ensure perspective, and provide a single pair of eyes in the design of Fleet's REST API and API documentation, there is a single Directly Responsible Individual (DRI). The API design DRI will review and approve any alterations at the pull request stage, instead of making it a prerequisite during drafting of the story. You may tag the DRI in a GitHub issue with draft API specs in place to receive a review and feedback prior to implementation. Receiving a pre-review from the DRI is encouraged if the API changes introduce new endpoints, or substantially change existing endpoints. - -> DRI: Rachael Shaw +To maintain consistency, ensure perspective, and provide a single pair of eyes in the design of Fleet's REST API and API documentation, there is a single Directly Responsible Individual (DRI). The API design DRI will review and approve any alterations at the pull request stage, instead of making it a prerequisite during drafting of the story. You may tag the DRI in a GitHub issue with draft API specs in place to receive a review and feedback prior to implementation. Receiving a pre-review from the DRI is encouraged if the API changes introduce new endpoints, or substantially change existing endpoints. No API changes are merged without accompanying API documentation and approval from the DRI. The DRI is responsible for ensuring that the API design remains consistent and adequately addresses both standard and edge-case scenarios. The DRI is also the code owner of the API documentation Markdown file. The DRI is committed to reviewing PRs within one business day. In instances where the DRI is unavailable, the Head of Product will act as the substitute code owner and reviewer.