From 6224a5f81fce38fac9d1f1fc06c428506e182929 Mon Sep 17 00:00:00 2001 From: Martin Angers Date: Wed, 9 Oct 2024 20:03:09 -0400 Subject: [PATCH] Fix: document `mdm_enrolled` activity limitations for Microsoft enrollments (#22793) --- changes/22532-document-mdm-enrolled-activity-limitations | 1 + docs/Contributing/Audit-logs.md | 4 ++-- server/fleet/activities.go | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 changes/22532-document-mdm-enrolled-activity-limitations diff --git a/changes/22532-document-mdm-enrolled-activity-limitations b/changes/22532-document-mdm-enrolled-activity-limitations new file mode 100644 index 000000000000..dd0acf4de84b --- /dev/null +++ b/changes/22532-document-mdm-enrolled-activity-limitations @@ -0,0 +1 @@ +* Documented that Microsoft enrollments have less fields filled in the `mdm_enrolled` activity due to how this MDM enrollment flow is implemented. diff --git a/docs/Contributing/Audit-logs.md b/docs/Contributing/Audit-logs.md index 3ef7e7a3fc78..2f12c87ff2f8 100644 --- a/docs/Contributing/Audit-logs.md +++ b/docs/Contributing/Audit-logs.md @@ -526,9 +526,9 @@ This activity contains the following fields: Generated when a host is enrolled in Fleet's MDM. This activity contains the following fields: -- "host_serial": Serial number of the host. +- "host_serial": Serial number of the host (Apple enrollments only, always empty for Microsoft). - "host_display_name": Display name of the host. -- "installed_from_dep": Whether the host was enrolled via DEP. +- "installed_from_dep": Whether the host was enrolled via DEP (Apple enrollments only, always false for Microsoft). - "mdm_platform": Used to distinguish between Apple and Microsoft enrollments. Can be "apple", "microsoft" or not present. If missing, this value is treated as "apple" for backwards compatibility. #### Example diff --git a/server/fleet/activities.go b/server/fleet/activities.go index 6e24ba3946e5..fcf91d4f8736 100644 --- a/server/fleet/activities.go +++ b/server/fleet/activities.go @@ -758,9 +758,9 @@ func (a ActivityTypeMDMEnrolled) ActivityName() string { func (a ActivityTypeMDMEnrolled) Documentation() (activity string, details string, detailsExample string) { return `Generated when a host is enrolled in Fleet's MDM.`, `This activity contains the following fields: -- "host_serial": Serial number of the host. +- "host_serial": Serial number of the host (Apple enrollments only, always empty for Microsoft). - "host_display_name": Display name of the host. -- "installed_from_dep": Whether the host was enrolled via DEP. +- "installed_from_dep": Whether the host was enrolled via DEP (Apple enrollments only, always false for Microsoft). - "mdm_platform": Used to distinguish between Apple and Microsoft enrollments. Can be "apple", "microsoft" or not present. If missing, this value is treated as "apple" for backwards compatibility.`, `{ "host_serial": "C08VQ2AXHT96", "host_display_name": "MacBookPro16,1 (C08VQ2AXHT96)",