Skip to content

Commit

Permalink
Include pre-releases when building osquery version list constant (#25089
Browse files Browse the repository at this point in the history
)

Also updates said constant via this script to include 5.15.0. Idea for
this is that including pre-releases as they're published ensures that by
the time the corresponding Fleet release ships we have a current list,
without having to cherry-pick these updates.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
  • Loading branch information
iansltx authored Jan 2, 2025
1 parent 425182c commit bbc35cb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .github/scripts/update_osquery_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ def fetch_osquery_versions():
resp = conn.getresponse()
content = resp.read()
conn.close()
releases = json.loads(content.decode('utf-8'))

return [release['tag_name'] for release in releases if not release['prerelease']]
return [release['tag_name'] for release in json.loads(content.decode('utf-8'))]

def update_min_osquery_version_options(new_versions):
with open(FILE_PATH, 'r') as file:
Expand Down
1 change: 1 addition & 0 deletions changes/osquery-constant-prerelease
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Included osquery pre-releases in daily UI constant update GitHub Actions job
1 change: 1 addition & 0 deletions frontend/utilities/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const MAX_OSQUERY_SCHEDULED_QUERY_INTERVAL = 604800;

export const MIN_OSQUERY_VERSION_OPTIONS = [
{ label: "All", value: "" },
{ label: "5.15.0 +", value: "5.15.0" },
{ label: "5.14.1 +", value: "5.14.1" },
{ label: "5.13.1 +", value: "5.13.1" },
{ label: "5.12.2 +", value: "5.12.2" },
Expand Down

0 comments on commit bbc35cb

Please sign in to comment.