From c39aea3b1bcddcd5606e5fcde64ff1be025ddad4 Mon Sep 17 00:00:00 2001 From: mostlikelee Date: Wed, 4 Dec 2024 18:04:02 -0700 Subject: [PATCH] comments and log update --- .github/workflows/fleet-and-orbit.yml | 7 +------ orbit/pkg/luks/luks_linux.go | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/fleet-and-orbit.yml b/.github/workflows/fleet-and-orbit.yml index d6881899f509..2dcdd6e87e35 100644 --- a/.github/workflows/fleet-and-orbit.yml +++ b/.github/workflows/fleet-and-orbit.yml @@ -213,12 +213,7 @@ jobs: # Here we generate the Fleet Desktop and osqueryd targets for # macOS which can only be generated from a macOS host. build-macos-targets: - # Set macOS version to '12' (current equivalent to macos-latest) for - # building the binary. This ensures compatibility with macOS version 13 and - # later, avoiding runtime errors on systems using macOS 13 or newer. - # - # Note: Update this version to '13' once GitHub marks macOS 13 as stable - # or if we revise our minimum supported macOS version. + # Set macOS version to '13' for building the binary as Fleet's minimum supported macOS version. runs-on: macos-13 steps: - name: Harden Runner diff --git a/orbit/pkg/luks/luks_linux.go b/orbit/pkg/luks/luks_linux.go index 253809b3bca3..9bea2759fbb8 100644 --- a/orbit/pkg/luks/luks_linux.go +++ b/orbit/pkg/luks/luks_linux.go @@ -127,7 +127,7 @@ func (lr *LuksRunner) getEscrowKey(ctx context.Context, devicePath string) ([]by } defer func() { if err := cancelProgress(); err != nil { - log.Error().Err(err).Msg("failed to cancel progress dialog") + log.Debug().Err(err).Msg("failed to cancel progress dialog") } }()