-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No information present in error modal when adding Fleet Maintained app #23096
Comments
Not able to reproduce this on a similarly throttled connection. Closing for now and will keep a look out for similar errors in the future. |
In the cloud city's glow, |
I ran into this while testing Create policies automatically for Fleet-maintained apps I'm getting the blank error message due to a timeout issue, waiting for server response. The FMA successfully uploads but because it thinks there was an error, the policy automation piece never completes. The user is not notified what went wrong, and the modal that should appear, does not. For FMA with automatic install policy creation, we should see something like this: |
moving to software board |
If need be, I'll ask @jmwatts for help reproducing-- should be a 1 if it's straight forward reproducing. |
I found these errors on #18865 figma: Notes from self testing this:
Is 3 intended? I tried to code the solution to this ticket as much as according to Figma spec in #18865. Anyone, feel free to correct me if there should be other error states instead. |
Being able to add a FMA over an existing title on a team is a bug. Mind filing that? That should be out of scope of this ticket as this scope looks limited to timeouts. |
Ack, I wasn't able to reproduce 3 real quick right now, I'll try again later today. If/when I do, I'll file the bug with reproduction steps. |
QA Notes Verified: |
Fleet version:
main
Web browser and operating system:
💥 Actual behavior
When adding software from the Fleet Maintained apps section and the request times out, an error modal is presented with no information.
🧑💻 Steps to reproduce
/software/add/fleet-maintained?team_id=#
page attempt to add software🕯️ More info (optional)
Picture of the behavior:
![image](https://private-user-images.githubusercontent.com/11012743/378995110-c9054714-242e-4106-a314-3de58f87b61d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjYxMjEsIm5iZiI6MTczOTUyNTgyMSwicGF0aCI6Ii8xMTAxMjc0My8zNzg5OTUxMTAtYzkwNTQ3MTQtMjQyZS00MTA2LWEzMTQtM2RlNThmODdiNjFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDA5MzcwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhMDFiZWRkNTM0NzRkODQ4M2FkNGFmY2Y4MjRhNTFmYTRhMTMyZTVmMDEzNTI3MTQ1YjYxYjkyYTBhYTA4NjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZCcDnRSYqBtXDCgHbngBcTE0gnWqlwgLm_DnyH-ZhbY)
The text was updated successfully, but these errors were encountered: