Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No information present in error modal when adding Fleet Maintained app #23096

Open
xpkoala opened this issue Oct 22, 2024 · 9 comments
Open

No information present in error modal when adding Fleet Maintained app #23096

xpkoala opened this issue Oct 22, 2024 · 9 comments
Assignees
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. :frontend #g-software Software product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@xpkoala
Copy link
Contributor

xpkoala commented Oct 22, 2024

Fleet version:main

Web browser and operating system:


💥  Actual behavior

When adding software from the Fleet Maintained apps section and the request times out, an error modal is presented with no information.

🧑‍💻  Steps to reproduce

  1. Slow network traffic
  2. On the /software/add/fleet-maintained?team_id=# page attempt to add software
  3. After a timeout period the blank error message will generate

🕯️ More info (optional)

Picture of the behavior:
image

@xpkoala xpkoala added bug Something isn't working as documented :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release. #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. :frontend labels Oct 22, 2024
@sharon-fdm sharon-fdm added :reproduce Involves documenting reproduction steps in the issue #g-mdm MDM product group and removed #g-endpoint-ops Endpoint ops product group labels Oct 28, 2024
@xpkoala
Copy link
Contributor Author

xpkoala commented Oct 28, 2024

Not able to reproduce this on a similarly throttled connection. Closing for now and will keep a look out for similar errors in the future.

@xpkoala xpkoala closed this as completed Oct 28, 2024
@fleet-release
Copy link
Contributor

In the cloud city's glow,
Fleet's silence unraveled, now
Errors bloom and show.

@jmwatts
Copy link
Member

jmwatts commented Dec 6, 2024

I ran into this while testing Create policies automatically for Fleet-maintained apps

Screenshot 2024-12-06 at 2 46 35 PM

I'm getting the blank error message due to a timeout issue, waiting for server response.

The FMA successfully uploads but because it thinks there was an error, the policy automation piece never completes.

The user is not notified what went wrong, and the modal that should appear, does not. For FMA with automatic install policy creation, we should see something like this:
Screenshot 2024-12-06 at 2 48 12 PM

@jmwatts jmwatts reopened this Dec 6, 2024
@georgekarrv georgekarrv removed the :reproduce Involves documenting reproduction steps in the issue label Dec 10, 2024
@georgekarrv georgekarrv added this to the 4.62.0-tentative milestone Dec 11, 2024
@marko-lisica marko-lisica changed the title No information present in error modal for Fleet Maintained app install failure No information present in error modal when adding Fleet Maintained app Dec 25, 2024
@jmwatts jmwatts added the ~frontend Frontend-related issue. label Jan 2, 2025
@getvictor getvictor modified the milestones: 4.62.0, 4.63.0-tentative Jan 8, 2025
@georgekarrv georgekarrv modified the milestones: 4.63.0, 4.64.0-tentative Jan 14, 2025
@mostlikelee mostlikelee added #g-software Software product group and removed #g-mdm MDM product group labels Jan 17, 2025
@mostlikelee
Copy link
Contributor

moving to software board

@mostlikelee mostlikelee removed the :incoming New issue in triage process. label Jan 20, 2025
@mostlikelee mostlikelee removed this from the 4.64.0-tentative milestone Jan 20, 2025
@RachelElysia
Copy link
Member

If need be, I'll ask @jmwatts for help reproducing-- should be a 1 if it's straight forward reproducing.

@RachelElysia
Copy link
Member

I found these errors on #18865 figma:

https://www.figma.com/design/bA6Y0QSQ3yvZpTAXbYa5Dn/%2318865-Fleet-maintained-apps-for-macOS?node-id=545-14976&t=S1DtNEgY6V0nIsIf-0

Notes from self testing this:

    1. We were just surfacing the error and if the error came back blank, we surfaced it.
    1. None of these errors were coded to Figma spec, so I'm wondering if I'm missing a conversation around it.
    1. The last error doesn't happen, I opened two browsers so I could try to override since somehow we hide FMA that are already installed (even if it's previously installed from the VPP page). I was able to add Software over the existing Software.

Is 3 intended? I tried to code the solution to this ticket as much as according to Figma spec in #18865. Anyone, feel free to correct me if there should be other error states instead.

@iansltx
Copy link
Member

iansltx commented Jan 22, 2025

Being able to add a FMA over an existing title on a team is a bug. Mind filing that? That should be out of scope of this ticket as this scope looks limited to timeouts.

@RachelElysia
Copy link
Member

Ack, I wasn't able to reproduce 3 real quick right now, I'll try again later today. If/when I do, I'll file the bug with reproduction steps.

@jmwatts
Copy link
Member

jmwatts commented Feb 4, 2025

QA Notes

Verified:
With slow network traffic (Chrome Dev Tools, 3G or switch to offline mid-upload)
On the /software/add/fleet-maintained?team_id=# page attempt to add software
After a timeout period the generic error message is shown "Couldn't add. Please try again."
Confirmed with FMA and Custom packages.

@mostlikelee mostlikelee added ~pushed User story was pushed to next release. and removed ~pushed User story was pushed to next release. labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. :frontend #g-software Software product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Development

No branches or pull requests

9 participants