Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add certificates to host vitals for macOS, iOS, iPadOS #23235

Open
15 tasks
noahtalerman opened this issue Oct 25, 2024 · 8 comments
Open
15 tasks

Add certificates to host vitals for macOS, iOS, iPadOS #23235

noahtalerman opened this issue Oct 25, 2024 · 8 comments
Assignees
@georgekarrv
Labels
~customer promise A feature request from a Fleet customer that Fleet has contractually agreed to deliver customer-pingali #g-mdm MDM product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Oct 25, 2024 •
edited
Loading

Goal

User story
As an IT admin on the Host details page,
I want to see a list of certificates on my macOS, iOS, and iPadOS hosts
so that I can understand if a missing/expired certificate is the reason why an end user can't connect to the corporate network.

Objective

Mission critical MDM replacement

Original requests

Context

Changes

Product

  • UI changes: Figma
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: PR
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: Fleet Free
  • Other reference documentation changes: No changes
  • Once shipped, requester has been notified

Engineering

  • Feature guide changes: TODO
  • Database schema migrations: TODO
  • Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@noahtalerman noahtalerman added story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group labels Oct 25, 2024
@noahtalerman noahtalerman mentioned this issue Oct 25, 2024
Open
@rachaelshaw rachaelshaw mentioned this issue Nov 11, 2024
Closed
@noahtalerman noahtalerman added Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. ~feature fest Will be reviewed at next Feature Fest and removed Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. ~feature fest Will be reviewed at next Feature Fest labels Nov 12, 2024
@noahtalerman noahtalerman added the ~customer promise A feature request from a Fleet customer that Fleet has contractually agreed to deliver label Nov 22, 2024
@noahtalerman noahtalerman added ~feature fest Will be reviewed at next Feature Fest and removed ~feature fest Will be reviewed at next Feature Fest labels Dec 5, 2024
@getvictor getvictor mentioned this issue Dec 19, 2024
Open
16 tasks
@noahtalerman noahtalerman added #g-mdm MDM product group and removed #g-endpoint-ops Endpoint ops product group labels Dec 19, 2024
@rachaelshaw rachaelshaw mentioned this issue Jan 9, 2025
Merged
rachaelshaw added a commit that referenced this issue Jan 9, 2025
@rachaelshaw
Docs: Update get host example (#25310)
d1a564e 
+ Update "Get host" example response to be a macOS host (in advance of
API design for #23235, since certificates will be available for
macOS/iOS/iPadOS)
+ Update formatting of "Get host by identifier" to move weightier items
to the bottom
@rachaelshaw rachaelshaw mentioned this issue Jan 9, 2025
Merged
rachaelshaw added a commit that referenced this issue Jan 9, 2025
@rachaelshaw
Docs: Update get host example response (#25313)
4f68dca 
Couple changes in advance of API design for #23235 (since certificates
will be available for macOS/iOS/iPadOS):
+ Update "Get host" example response to be a macOS host
+ Update "Get host by device token" example response to be a macOS host
& move weightier items to the bottom for readability
@rachaelshaw rachaelshaw mentioned this issue Jan 9, 2025
Merged
rachaelshaw added a commit that referenced this issue Jan 10, 2025
@rachaelshaw
#23235 API docs: Add certificates to host vitals for macOS, iOS, iPad…
0c52178 
…OS (#25317)

For #23235

Add `certificates` to "Get host" and "Get host by device token"
endpoints.
This list will be available for macOS, iOS, and iPadOS hosts. It will be
omitted for other platforms.
@noahtalerman
Copy link
Member Author

Hey @georgekarrv heads up that this story is ready to spec. Can you please complete the TODOs in the "Engineering" section so we can bring this one to estimation on Weds?

Note that this story and #17700 are the last stories that won't go through the new User story review meeting before estimation.

cc @lukeheath

@lukeheath
Copy link
Member

@noahtalerman Would you please add the last line to the user story? "So I can..." That will help give us context on why the admin wants to do this. Thanks!

@noahtalerman
Copy link
Member Author

@noahtalerman Would you please add the last line to the user story? "So I can..." That will help give us context on why the admin wants to do this. Thanks!

User story
As an IT admin on the Host details page,
I want to see a list of certificates on my macOS, iOS, and iPadOS hosts
so that I can understand if a missing/expired certificate is the reason why an end user can't connect to the corporate network.

Yep! Added. @georgekarrv just a reminder that this one is ready to spec.

@noahtalerman
Copy link
Member Author

@rachaelshaw reminder to include to the "so..." clause when writing user stories: #23235 (comment)

@noahtalerman
Copy link
Member Author

Hey @georgekarrv just a reminder that this story is ready for spec. Can you please complete the TODOs in the "Engineering" section so we can bring this one to estimation today?

cc @rachaelshaw

@georgekarrv
Copy link
Member

After reviewing the API spec I would not say that I agree with adding a list of certificates to the host details information (already a pretty bloated endpoint) and would recommend adding either a trimmed amount of data that is requested for this story (id, name, expiry) add total count and limit to the first 5 or make a paginated separate endpoint.

Either way I would recommend the detail endpoint be separate instead of just referencing all of the data from the host details ep.

@noahtalerman
Copy link
Member Author

@georgekarrv looks like this story is estimated so I moved it to the estimated column.

@lukeheath lukeheath added customer-pingali P2 Prioritize as urgent and removed P2 Prioritize as urgent labels Jan 17, 2025
@georgekarrv
Copy link
Member

Just a reminder that this is a pre-requisite for the #24468 story and should be done in the sprint prior to working on renewing NDES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgekarrv georgekarrv

Labels
~customer promise A feature request from a Fleet customer that Fleet has contractually agreed to deliver customer-pingali #g-mdm MDM product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@georgekarrv @lukeheath @rachaelshaw @noahtalerman