diff --git a/changes/16817-ms-edge-vuln b/changes/16817-ms-edge-vuln new file mode 100644 index 000000000000..56b766436875 --- /dev/null +++ b/changes/16817-ms-edge-vuln @@ -0,0 +1 @@ +- Fixed issue where microsoft edge was not reporting vulnerabilities \ No newline at end of file diff --git a/server/vulnerabilities/nvd/README.md b/server/vulnerabilities/nvd/README.md index 5a2dc0b6f2d1..6f921290e923 100644 --- a/server/vulnerabilities/nvd/README.md +++ b/server/vulnerabilities/nvd/README.md @@ -10,17 +10,24 @@ To test these changes locally, you can: 2. host this file on a local web server ```bash - ./tools/file-server 8082 ./server/vulnerabilities/nvd/cpe_translations.json + go run ./tools/file-server 8082 ./server/vulnerabilities/nvd ``` -3. (re)launch your local fleet server with the following `--config` +3. (re)launch your local fleet server with one of the following + Config method ```yaml vulnerabilities: cpe_translations_url: "http://localhost:8082/cpe_translations.json" ``` -4. trigger the vulnerabilities scan + + Environment method + ```bash + FLEET_VULNERABILITIES_CPE_TRANSLATIONS_URL="http://localhost:8082/cpe_translations.json" ./build/fleet serve --dev --dev_license --logging_debug + ``` + +4. trigger a vulnerabilities scan ```bash fleetctl trigger --name vulnerabilities diff --git a/server/vulnerabilities/nvd/cpe_test.go b/server/vulnerabilities/nvd/cpe_test.go index 95adccea2bdf..bef27faf307b 100644 --- a/server/vulnerabilities/nvd/cpe_test.go +++ b/server/vulnerabilities/nvd/cpe_test.go @@ -823,7 +823,7 @@ func TestCPEFromSoftwareIntegration(t *testing.T) { Version: "105.0.1343.50", Vendor: "Microsoft Corporation", BundleIdentifier: "", - }, cpe: "cpe:2.3:a:microsoft:edge:105.0.1343.50:*:*:*:*:windows:*:*", + }, cpe: "cpe:2.3:a:microsoft:edge_chromium:105.0.1343.50:*:*:*:*:windows:*:*", }, { software: fleet.Software{ diff --git a/server/vulnerabilities/nvd/cpe_translations.json b/server/vulnerabilities/nvd/cpe_translations.json index fd6e367a2333..2fde92baff8a 100644 --- a/server/vulnerabilities/nvd/cpe_translations.json +++ b/server/vulnerabilities/nvd/cpe_translations.json @@ -139,5 +139,15 @@ "product": ["pycharm"], "vendor": ["jetbrains"] } + }, + { + "software": { + "name": ["Microsoft Edge"], + "source": ["programs", "apps"] + }, + "filter": { + "product": ["edge_chromium"], + "vendor": ["microsoft"] + } } ]