chore: moving diverged states from error to completed (#3022)

Author: momchil-flex

tests/_test_notebooks/full_test_notebooks.py

@@ -60,11 +60,15 @@
     "FocusedApodGC",
     "GeneticAlgorithmReflector",
     "ParticleSwarmOptimizedPBS",
-    # hang by default
+    "DirectionalCouplerSurrogate.ipynb",
+    # hang or error by default
+    "AdvancedGaussianSources.ipynb",
     "AdjointPlugin14PreFab.ipynb",
     "Autograd23FabricationAwareInvdes",
+    "KLayoutPlugin_DRCQuickstart.ipynb",
     "SimpleModeSolverGUI",
     "WaveguideBendSimulator",
+    "GUIDataTutorial.ipynb",
 ]
 
 # if any run only supplied, only add those
@@ -78,32 +82,23 @@
         notebook_filenames.append(fname)
 
 """
-as of Dec 12 2024
+as of Nov 23 2025
 '8ChannelDemultiplexer',
 '90BendPolarizationSplitterRotator',
 '90OpticalHybrid',
+'AbsorbingBoundaryReflection',
 'AdiabaticCouplerLN',
-'AdjointPlugin0Quickstart',
-'AdjointPlugin10YBranchLevelSet',
-'AdjointPlugin11CircuitMZI',
-'AdjointPlugin12LightExtractor',
-'AdjointPlugin13Metasurface',
-'AdjointPlugin14PreFab',
-'AdjointPlugin1Intro',
-'AdjointPlugin2GradientChecking',
-'AdjointPlugin3InverseDesign',
-'AdjointPlugin4MultiObjective',
-'AdjointPlugin5BoundaryGradients',
-'AdjointPlugin6GratingCoupler',
-'AdjointPlugin7Metalens',
-'AdjointPlugin8WaveguideBend',
-'AdjointPlugin9WDM',
+'AdvancedGaussianSources',
 'AllDielectricStructuralColor',
 'AndersonLocalization',
 'AnimationTutorial',
+'AnisotropicMetamaterialBroadbandPBS',
+'AntennaCharacteristics',
 'AntiResonantHollowCoreFiber',
 'AutoGrid',
+'Autograd0Overview',
 'Autograd0Quickstart',
+'Autograd0QuickstartII',
 'Autograd10YBranchLevelSet',
 'Autograd12LightExtractor',
 'Autograd13Metasurface',
@@ -117,6 +112,8 @@
 'Autograd21GaPLightExtractor',
 'Autograd22PhotonicCrystal',
 'Autograd23FabricationAwareInvdes',
+'Autograd24DigitalSplitter',
+'Autograd26Smatrix',
 'Autograd2GradientChecking',
 'Autograd3InverseDesign',
 'Autograd4MultiObjective',
@@ -132,26 +129,37 @@
 'BilevelPSR',
 'BiosensorGrating',
 'BistablePCCavity',
+'BlueMicroLED',
 'BoundaryConditions',
 'BraggGratings',
 'BroadbandDirectionalCoupler',
 'BroadbandPlaneWaveWithConstantObliqueIncidentAngle',
 'BullseyeCavityPSO',
 'CMOSRGBSensor',
+'CPWRFPhotonics1',
+'CPWRFPhotonics2',
 'CavityFOM',
 'CharacteristicImpedanceCalculator',
+'ChargeSolver',
 'CircularlyPolarizedPatchAntenna',
 'CoupledLineBandpassFilter',
 'CreatingGeometryUsingTrimesh',
 'CustomFieldSource',
 'CustomMediumTutorial',
 'Design',
 'DielectricMetasurfaceAbsorber',
+'DifferentialStripline',
+'DirectionalCoupler',
+'DirectionalCouplerSurrogate',
+'DirectionalScatteringNanodisks',
+'DisorderedPlasmonicColor',
 'Dispersion',
 'DistributedBraggReflectorCavity',
 'DivergedFDTDSimulation',
+'EMEBends',
 'EMESolver',
 'EdgeCoupler',
+'EdgeFeedPatchAntennaBenchmark',
 'EffectiveIndexApproximation',
 'EulerWaveguideBend',
 'FieldProjections',
@@ -160,33 +168,46 @@
 'FreeFormCoupler',
 'FresnelLens',
 'FullyAnisotropic',
+'GDSCreation',
 'GDSExport',
 'GDSImport',
+'GUIDataTutorial',
 'GeneticAlgorithmReflector',
 'GeometryTransformations',
 'GradientMetasurfaceReflector',
 'GrapheneMetamaterial',
 'GratingCoupler',
 'GratingEfficiency',
+'GroundedCPWViaFence',
+'GroupDelayCalculation',
 'Gyrotropic',
+'HeatDissipationSOI',
 'HeatSolver',
 'HighQGe',
 'HighQSi',
+'HybridMicrostripCPWBandpassFilter',
 'IntegratedVivaldiAntenna',
 'InverseDesign',
+'KLayoutPlugin_DRCQuickstart',
 'KerrSidebands',
 'LNOIPolarizationSplitterRotator',
+'LayerRefinement',
 'LinearLumpedElements',
+'LowContrastWaveguide',
 'MIMResonator',
 'MMI1x4',
+'MMIMeepBenchmark',
 'MachZehnderModulator',
 'MetalHeaterPhaseShifter',
 'MetalOxideSunscreen',
 'Metalens',
+'MetasurfaceBIC',
+'MicroringRFElectrode',
 'MicrowaveFrequencySelectiveSurface',
 'MidIRMetalens',
 'MoS2Waveguide',
 'ModalSourcesMonitors',
+'ModeOverlap',
 'ModeSolver',
 'ModesBentAngled',
 'MultiplexingMMI',
@@ -198,29 +219,37 @@
 'OpticalLuneburgLens',
 'OpticalSwitchDBS',
 'OptimizedL3',
+'PCMBraggGratingFilter',
+'PECSphereRCS',
 'PICComponents',
 'ParameterScan',
 'ParticleSwarmOptimizedPBS',
 'PhotonicCrystalWaveguidePolarizationFilter',
 'PhotonicCrystalsComponents',
 'PlasmonicNanoparticle',
 'PlasmonicNanorodArray',
+'PlasmonicPhotothermalHeating',
 'PlasmonicWaveguideCO2Sensor',
 'PlasmonicYagiUdaNanoantenna',
 'PolarizationSplitterRotator',
 'Primer',
+'RadarAbsorbingMetamaterial',
 'RadiativeCoolingGlass',
 'RadiativeLossesModeSolver',
 'ResonanceFinder',
 'RingResonator',
+'SMAEdgeMount',
 'SMatrix',
 'STLImport',
 'SWGBroadbandPolarizer',
+'SWGWaveguideCrossing',
 'SbendCMAES',
 'ScaleInvariantWaveguide',
 'SelfIntersectingPolyslab',
+'SiWaveguideTPA',
 'SimpleModeSolverGUI',
 'Simulation',
+'SourceNormalization',
 'StartHere',
 'StripToSlotConverters',
 'Symmetry',
@@ -229,19 +258,26 @@
 'TaperedWgDispersion',
 'ThermallyTunedRingResonator',
 'ThermoOpticDopedModulator',
+'ThroughSiliconVia',
+'TidyFab0GC',
 'TimeModulationTutorial',
+'TopoQuantumPhC',
 'TunableChiralMetasurface',
 'UnstructuredData',
 'VizData',
 'VizSimulation',
 'VortexMetasurface',
+'WPDHarmonicSuppression1',
+'WPDHarmonicSuppression2',
+'WPDHarmonicSuppression3',
 'WaveguideBendSimulator',
 'WaveguideCrossing',
 'WaveguideGratingAntenna',
 'WaveguidePluginDemonstration',
 'WaveguideSizeConverter',
 'WaveguideToRingCoupling',
 'WebAPI',
+'WidebandBeamSteerableReflectarrayWithPRUC',
 'XarrayTutorial',
 'YJunction',
 'ZeroCrossTalkTE',

tidy3d/plugins/invdes/validators.py

@@ -48,7 +48,7 @@ def check_pixel_size_sim(
 
             td.log.warning(
                 f"'DesignRegion.pixel_size' is '{pixel_size}', which is large compared to "
-                f"the minimum wavelength in {sim_string}: '{sim.wvl_mat_min}'. For best results, "
+                f"the minimum wavelength in the material '{sim.wvl_mat_min}' in {sim_string}. For best results, "
                 f"we recommend setting it at most {PIXEL_SIZE_WARNING_THRESHOLD} times the minimum "
                 f"wavelength ({PIXEL_SIZE_WARNING_THRESHOLD * sim.wvl_mat_min}). "
                 "Note: to set the grid size within the design region independent of the parameter "

tidy3d/web/api/states.py

@@ -8,8 +8,6 @@
     "validate_error",
     "error",
     "errored",
-    "diverge",
-    "diverged",
     "blocked",
     "preprocess_error",
     "run_error",
@@ -32,7 +30,15 @@
     "run_success",
 }
 
-COMPLETED_STATES = {"visualize", "success", "completed", "processed", "postprocess_success"}
+COMPLETED_STATES = {
+    "visualize",
+    "success",
+    "completed",
+    "processed",
+    "postprocess_success",
+    "diverge",
+    "diverged",
+}
 
 END_STATES = ERROR_STATES | COMPLETED_STATES
 
@@ -87,13 +93,13 @@
     "success": COMPLETED_PERCENT,  # 100%
     "completed": COMPLETED_PERCENT,  # 100%
     "postprocess_success": COMPLETED_PERCENT,  # 100%
+    "diverge": COMPLETED_PERCENT,
+    "diverged": COMPLETED_PERCENT,
     # --- Error States ---
     # All error states map to 0%
     "validate_fail": 0,
     "error": 0,
     "errored": 0,
-    "diverge": 0,
-    "diverged": 0,
     "blocked": 0,
     "run_failed": 0,
     "aborted": 0,