-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong syntax of @method tags in Flight class docblock #608
Comments
Hi @anthonyaxenov edit: just checked and phpstan does indeed support this syntax (https://phpstan.org/r/948cd893-1920-49e6-9f19-02413890e577) |
|
Thanks again for bringing this issue up and lets hope that JetBrains will fix the type discovery on their side. If not we might need to revisit this again here and look if we can improve that in flight itselt. |
Some
@method
s are described incorrectly.Types here should be in native php syntax and there is no way to describe generic types in
@method
s directly. Generic types are allowed in@param
,@return
and@template*
tags. Otherwise IDE will not parse such method correctly.Just a small example with
Flight::set()
:I didn't looked up closely in other files but it definitely worth to do
Reference: https://github.com/flightphp/core/blob/master/flight/Flight.php#L21-L81
Found in mikecao/flight v3.12.0
The text was updated successfully, but these errors were encountered: