Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new rankTransform() to use in plotResiduals / testQuantiles #467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

new rankTransform() to use in plotResiduals / testQuantiles #467

wants to merge 2 commits into from

Conversation

melina-leite
Copy link
Collaborator

included rank = T as argument in testQuantiles
included rankTransform in plotResiduals and testQuantile

This closes the inconsistency in issue #465.

@melina-leite
new rankTransform() to use in plotResiduals / testQuantiles
d36ee45 
included rank = T as argument in testQuantiles
included rankTransform in plotResiduals and testQuantile
@melina-leite melina-leite linked an issue Feb 28, 2025 that may be closed by this pull request
p-values inconsistent in testQuantiles with plot = T and plot = F #465
Open
@melina-leite
Copy link
Collaborator Author

example code for manual test:

library(DHARMa)
library(lme4)

testData = createData(sampleSize = 100,  family = poisson())
fittedModel <- glmer(observedResponse ~ Environment1 + (1|group), 
                     family = "poisson", data = testData)

res <- simulateResiduals(fittedModel = fittedModel)

testQuantiles(res, plot = T) # testing default rank=T
testQuantiles(res, plot = F) # testing default rank=T
plotResiduals(res)$p.value # testing default rank=T

testQuantiles(res, plot = T, rank=T)
testQuantiles(res, plot = F, rank=T)
plotResiduals(res, rank=T)$p.value

testQuantiles(res, plot = T, rank=F)
testQuantiles(res, plot = F, rank=F)
plotResiduals(res, rank=F)$p.value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

p-values inconsistent in testQuantiles with plot = T and plot = F
1 participant
@melina-leite