From e6376746c1236bc8d6924b487f2df29fe4022cf2 Mon Sep 17 00:00:00 2001
From: Filip Hrisafov <filip.hrisafov@gmail.com>
Date: Tue, 2 Aug 2022 16:44:48 +0200
Subject: [PATCH] Update database workflows

* Always use MySQL 8.0 (the bug that we had has been fixed)
* Remove Oracle 11 and add 21
* Remove Postgres 9 and 10 and add 14
* Add SQL Server 2019
---
 .github/workflows/mysql.yml      | 12 +++---------
 .github/workflows/oracle.yml     | 30 +++++++++++++++---------------
 .github/workflows/postgres.yml   |  6 +++---
 .github/workflows/sql-server.yml |  6 +++---
 4 files changed, 24 insertions(+), 30 deletions(-)

diff --git a/.github/workflows/mysql.yml b/.github/workflows/mysql.yml
index 5ed1c5c84bb..a2b0f6afdd4 100644
--- a/.github/workflows/mysql.yml
+++ b/.github/workflows/mysql.yml
@@ -20,9 +20,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # Not testing with latest 8 since they have a bug for exists sub query with order by in the outer
-        # See https://bugs.mysql.com/bug.php?id=99019
-        mysql: [5.7, 8.0.18]
+        mysql: [5.7, 8.0]
     services:
       mysql:
         image: mysql:${{ matrix.mysql }}
@@ -63,9 +61,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # Not testing with latest 8 since they have a bug for exists sub query with order by in the outer
-        # See https://bugs.mysql.com/bug.php?id=99019
-        mysql: [5.7, 8.0.18]
+        mysql: [5.7, 8.0]
     services:
       mysql:
         image: mysql:${{ matrix.mysql }}
@@ -107,9 +103,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # Not testing with latest 8 since they have a bug for exists sub query with order by in the outer
-        # See https://bugs.mysql.com/bug.php?id=99019
-        mysql: [5.7, 8.0.18]
+        mysql: [5.7, 8.0]
     services:
       mysql:
         image: mysql:${{ matrix.mysql }}
diff --git a/.github/workflows/oracle.yml b/.github/workflows/oracle.yml
index 9c29ba4cd7e..017b07abbb5 100644
--- a/.github/workflows/oracle.yml
+++ b/.github/workflows/oracle.yml
@@ -18,16 +18,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        oracle: [ "11-slim", "18-slim" ]
+        oracle: [ "18-slim", "21-slim" ]
         include:
-          - oracle: 11-slim
-            driverVersion: 11.2.0.4
-            driverArtifact: ojdbc6
-            serviceName: XE
           - oracle: 18-slim
             driverVersion: 18.3.0.0
             driverArtifact: ojdbc8
             serviceName: XEPDB1
+          - oracle: 21-slim
+            driverVersion: 21.6.0.0.1
+            driverArtifact: ojdbc8
+            serviceName: XEPDB1
     services:
       oracle:
         image: gvenzl/oracle-xe:${{ matrix.oracle }}
@@ -70,16 +70,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        oracle: [ "11-slim", "18-slim" ]
+        oracle: [ "18-slim", "21-slim" ]
         include:
-          - oracle: 11-slim
-            driverVersion: 11.2.0.4
-            driverArtifact: ojdbc6
-            serviceName: XE
           - oracle: 18-slim
             driverVersion: 18.3.0.0
             driverArtifact: ojdbc8
             serviceName: XEPDB1
+          - oracle: 21-slim
+            driverVersion: 21.6.0.0.1
+            driverArtifact: ojdbc8
+            serviceName: XEPDB1
     services:
       oracle:
         image: gvenzl/oracle-xe:${{ matrix.oracle }}
@@ -123,16 +123,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        oracle: [ "11-slim", "18-slim" ]
+        oracle: [ "18-slim", "21-slim" ]
         include:
-          - oracle: 11-slim
-            driverVersion: 11.2.0.4
-            driverArtifact: ojdbc6
-            serviceName: XE
           - oracle: 18-slim
             driverVersion: 18.3.0.0
             driverArtifact: ojdbc8
             serviceName: XEPDB1
+          - oracle: 21-slim
+            driverVersion: 21.6.0.0.1
+            driverArtifact: ojdbc8
+            serviceName: XEPDB1
     services:
       oracle:
         image: gvenzl/oracle-xe:${{ matrix.oracle }}
diff --git a/.github/workflows/postgres.yml b/.github/workflows/postgres.yml
index 2f15f43fe31..a30a5e40517 100644
--- a/.github/workflows/postgres.yml
+++ b/.github/workflows/postgres.yml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        postgres: [10, 11, 12, 13, 14]
+        postgres: [11, 12, 13, 14]
     services:
       postgres:
         image: postgres:${{ matrix.postgres }}
@@ -57,7 +57,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        postgres: [9, 10, 11, 12, 13]
+        postgres: [11, 12, 13, 14]
     services:
       postgres:
         image: postgres:${{ matrix.postgres }}
@@ -96,7 +96,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        postgres: [9, 10, 11, 12, 13]
+        postgres: [11, 12, 13, 14]
     services:
       postgres:
         image: postgres:${{ matrix.postgres }}
diff --git a/.github/workflows/sql-server.yml b/.github/workflows/sql-server.yml
index a838842a418..b7b291fde86 100644
--- a/.github/workflows/sql-server.yml
+++ b/.github/workflows/sql-server.yml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        mssql: [2017-latest-ubuntu]
+        mssql: [2017-latest-ubuntu, 2019-latest]
     services:
       mssql:
         image: mcr.microsoft.com/mssql/server:${{ matrix.mssql }}
@@ -69,7 +69,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        mssql: [2017-latest-ubuntu]
+        mssql: [2017-latest-ubuntu, 2019-latest]
     services:
       mssql:
         image: mcr.microsoft.com/mssql/server:${{ matrix.mssql }}
@@ -120,7 +120,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        mssql: [2017-latest-ubuntu]
+        mssql: [2017-latest-ubuntu, 2019-latest]
     services:
       mssql:
         image: mcr.microsoft.com/mssql/server:${{ matrix.mssql }}