Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scheme for compound query requests #1029

Closed
LukasPietzschmann opened this issue Oct 2, 2024 · 2 comments
Closed

Wrong scheme for compound query requests #1029

LukasPietzschmann opened this issue Oct 2, 2024 · 2 comments
Labels
query api relates to the query api server Has to do with flowR's server

Comments

@LukasPietzschmann
Copy link
Collaborator

I was unsure if this should be tracked in #1007 or if a separate issue would be better, so feel free to close this one if #1007 is a better place for it.


As mentioned in the doc, compound queries could look like the following:

[
  {
    "type": "compound",
    "query": "call-context",
    "commonArguments": {
      "kind": "visualize",
      "subkind": "text"
    },
    "arguments": [
      {
        "callName": "^mean$"
      },
      {
        "callName": "^print$"
      }
    ]
  }
]

Note that we do not need to specify the type of all arguments, since it's already given in the query field. The scheme checked by the server however enforces the type field inside all arguments.

@LukasPietzschmann LukasPietzschmann added server Has to do with flowR's server query api relates to the query api labels Oct 2, 2024
@EagleoutIce
Copy link
Member

Yes, thank you, this is already fixed in the stage of v2.1.0 which (automatically) updates the documentation accordingly and refines the schema generation! I hope i can merge it soon.

@LukasPietzschmann
Copy link
Collaborator Author

Ah, sorry! I did not check there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query api relates to the query api server Has to do with flowR's server
Projects
None yet
Development

No branches or pull requests

2 participants