Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release workflow fails to detect changelog (+ we want the changelog to be auto-populated from the git history) #82

Open
Ellpeck opened this issue May 8, 2024 · 3 comments · Fixed by #83 · May be fixed by #114
Open

Release workflow fails to detect changelog (+ we want the changelog to be auto-populated from the git history) #82

Ellpeck opened this issue May 8, 2024 · 3 comments · Fixed by #83 · May be fixed by #114
Assignees
@Ellpeck
Labels
bug Something isn't working enhancement New feature or request

Comments

@Ellpeck
Copy link
Member

Ellpeck commented May 8, 2024

This is due to the fact that version tags get the letter v prepended, which the code to gather the correct changelog section doesn't account for.
@Ellpeck Ellpeck linked a pull request May 8, 2024 that will close this issue
Various small fixes and improvements #83
Merged
@Ellpeck
Copy link
Member Author

Ellpeck commented May 8, 2024

detects the changelog now, but only the first line :(

@Ellpeck Ellpeck reopened this May 8, 2024
@Ellpeck Ellpeck mentioned this issue Jun 25, 2024
Merged
@Ellpeck Ellpeck added the bug Something isn't working label Jun 25, 2024
@Ellpeck Ellpeck self-assigned this Jun 25, 2024
@Ellpeck
Copy link
Member Author

Ellpeck commented Oct 1, 2024

Maybe checking out with the GH action only checks out the most recent commit?? fetch-depth: 0 time

@Ellpeck Ellpeck changed the title Release workflow fails to detect changelog Release workflow fails to detect changelog (+ we want the changelog to be auto-populated from the git history) Oct 1, 2024
@Ellpeck Ellpeck added the enhancement New feature or request label Oct 1, 2024
@Ellpeck
Copy link
Member Author

Ellpeck commented Oct 1, 2024 •
edited
Loading

+ when making an update, the changelog should be populated with commit messages from all of the commits since the last release/tag.

@Ellpeck Ellpeck linked a pull request Oct 1, 2024 that will close this issue
Changelog fixes #114
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ellpeck Ellpeck

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Ellpeck