Skip to content

Conversation

@zwbrealm
Copy link

@zwbrealm zwbrealm commented Oct 20, 2024

Ⅰ. Describe what this PR does

1.在alluxio runtime type中增加workerType字段,用来指示worker类型(STS,ASTS,DaemonSet)
2.增加cacheworkerset 定义以及相关属性的GET/SET操作(pkg/types/cacheworkerset/interface.go)
3.引入了openkruise依赖后,根据它的特性,只需要手动对work pod的label进行patch SpecifiedDeleteKey = "apps.kruise.io/specified-delete",且这些worker pod被openkruise advanced statefulset接管,那么就可以做到指定该pod下线了。

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

labels:
app: sample
spec:
containers:

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this resource's automounted service account to RBAC or disable automounting. See more on SonarQube Cloud
app: sample
spec:
containers:
- name: main

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarQube Cloud
app: sample
spec:
containers:
- name: main

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant