This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Commit dcfbbd7
authored
embedder: fix bit-order in software pixel format description (#57156)
The order of the components for packed software pixel formats is incorrectly documented as being the order in the native type, least-significant-bit first. In reality it's the other way around. For example, for `RGB565`, the `R` is the 5 most significant bits in the 2-byte pixel value, rather than the least significant bits. The test even verify it is that way:
https://github.com/flutter/engine/blob/main/shell/platform/embedder/tests/embedder_unittests.cc#L2782-L2785
I assume noone used the software pixel formats until @sodiboo did, that's why it's gone unnoticed for so long.
Also contains some other minor documentation improvements.
- Issue: flutter/flutter#160149
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style1 parent 0d5a750 commit dcfbbd7
1 file changed
+25
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
355 | 358 | | |
356 | 359 | | |
357 | 360 | | |
358 | 361 | | |
359 | 362 | | |
360 | 363 | | |
361 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
362 | 368 | | |
363 | 369 | | |
364 | 370 | | |
365 | 371 | | |
366 | 372 | | |
367 | 373 | | |
368 | 374 | | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
369 | 378 | | |
370 | 379 | | |
371 | 380 | | |
372 | 381 | | |
373 | 382 | | |
374 | 383 | | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
375 | 387 | | |
376 | 388 | | |
377 | 389 | | |
378 | 390 | | |
379 | 391 | | |
380 | 392 | | |
381 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
382 | 397 | | |
383 | 398 | | |
384 | 399 | | |
| |||
1741 | 1756 | | |
1742 | 1757 | | |
1743 | 1758 | | |
1744 | | - | |
| 1759 | + | |
| 1760 | + | |
1745 | 1761 | | |
1746 | 1762 | | |
1747 | 1763 | | |
| |||
2011 | 2027 | | |
2012 | 2028 | | |
2013 | 2029 | | |
| 2030 | + | |
| 2031 | + | |
| 2032 | + | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
| 2037 | + | |
2014 | 2038 | | |
2015 | 2039 | | |
2016 | 2040 | | |
| |||
0 commit comments