From 2bbaa82e09117471a567db4d2129ea4285efeb63 Mon Sep 17 00:00:00 2001
From: Robert Ancell <robert.ancell@canonical.com>
Date: Thu, 12 Dec 2024 10:36:14 +1300
Subject: [PATCH] Migrate FlPlatformChannel tests to FlMockBinaryMessenger

---
 .../linux/fl_platform_channel_test.cc         | 60 ++++++++++---------
 1 file changed, 32 insertions(+), 28 deletions(-)

diff --git a/shell/platform/linux/fl_platform_channel_test.cc b/shell/platform/linux/fl_platform_channel_test.cc
index 45aeeef2a0531..6161126a165c2 100644
--- a/shell/platform/linux/fl_platform_channel_test.cc
+++ b/shell/platform/linux/fl_platform_channel_test.cc
@@ -3,41 +3,45 @@
 // found in the LICENSE file.
 
 #include "flutter/shell/platform/linux/fl_platform_channel.h"
-#include "flutter/shell/platform/linux/fl_binary_messenger_private.h"
 #include "flutter/shell/platform/linux/public/flutter_linux/fl_method_channel.h"
 #include "flutter/shell/platform/linux/public/flutter_linux/fl_standard_method_codec.h"
-#include "flutter/shell/platform/linux/testing/fl_test.h"
-#include "gtest/gtest.h"
-
-static void exit_method_response_cb(GObject* object,
-                                    GAsyncResult* result,
-                                    gpointer user_data) {
-  g_autoptr(GError) error = nullptr;
-  FlPlatformChannelExitResponse response;
-  gboolean success = fl_platform_channel_system_request_app_exit_finish(
-      object, result, &response, &error);
+#include "flutter/shell/platform/linux/testing/fl_mock_binary_messenger.h"
 
-  EXPECT_TRUE(success);
-  EXPECT_EQ(response, FL_PLATFORM_CHANNEL_EXIT_RESPONSE_EXIT);
-
-  g_main_loop_quit(static_cast<GMainLoop*>(user_data));
-}
+#include "gtest/gtest.h"
 
 TEST(FlPlatformChannelTest, ExitResponse) {
   g_autoptr(GMainLoop) loop = g_main_loop_new(nullptr, 0);
 
-  g_autoptr(FlEngine) engine = make_mock_engine();
-  g_autoptr(FlBinaryMessenger) messenger = fl_binary_messenger_new(engine);
-  g_autoptr(FlStandardMethodCodec) codec = fl_standard_method_codec_new();
-  g_autoptr(FlMethodChannel) channel = fl_method_channel_new(
-      messenger, "test/standard-method", FL_METHOD_CODEC(codec));
-
-  g_autoptr(FlValue) args = fl_value_new_map();
-  fl_value_set_string_take(args, "response", fl_value_new_string("exit"));
-
-  fl_method_channel_invoke_method(channel, "Echo", args, nullptr,
-                                  exit_method_response_cb, loop);
+  g_autoptr(FlMockBinaryMessenger) messenger = fl_mock_binary_messenger_new();
+  fl_mock_binary_messenger_set_json_method_channel(
+      messenger, "flutter/platform",
+      [](FlMockBinaryMessenger* messenger, const gchar* name, FlValue* args,
+         gpointer user_data) {
+        EXPECT_STREQ(name, "System.requestAppExit");
+        g_autoptr(FlValue) return_value = fl_value_new_map();
+        fl_value_set_string_take(return_value, "response",
+                                 fl_value_new_string("exit"));
+        return FL_METHOD_RESPONSE(fl_method_success_response_new(return_value));
+      },
+      nullptr);
+
+  FlPlatformChannelVTable vtable;
+  g_autoptr(FlPlatformChannel) channel =
+      fl_platform_channel_new(FL_BINARY_MESSENGER(messenger), &vtable, nullptr);
+  fl_platform_channel_system_request_app_exit(
+      channel, FL_PLATFORM_CHANNEL_EXIT_TYPE_REQUIRED, nullptr,
+      [](GObject* object, GAsyncResult* result, gpointer user_data) {
+        g_autoptr(GError) error = nullptr;
+        FlPlatformChannelExitResponse response;
+        gboolean success = fl_platform_channel_system_request_app_exit_finish(
+            object, result, &response, &error);
+
+        EXPECT_TRUE(success);
+        EXPECT_EQ(response, FL_PLATFORM_CHANNEL_EXIT_RESPONSE_EXIT);
+
+        g_main_loop_quit(static_cast<GMainLoop*>(user_data));
+      },
+      loop);
 
-  // Blocks here until method_response_cb is called.
   g_main_loop_run(loop);
 }