Skip to content

package:web_benchmarks needs to be updated for unified skwasm/canvaskit renderers #177057

@elliette

Description

@elliette

Now that the skwasm and canvaskit renderers emit the same frame events (see #175392), the expectedBenchmarkMetrics method here [1] no longer returns the expected events. They are now be the same for both skwasm and canvaskit.

To handle this, I suggest making useWasm an optional named parameter instead of required.

[1] https://github.com/flutter/packages/blob/1c0be204c45eea42927eb6005bb45f16a8fffb07/packages/web_benchmarks/lib/src/metrics.dart#L152-L155

(Note: This was noticed because the DevTools benchmark tests to began failing, see flutter/devtools#9456)

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: proposalA detailed proposal for a change to Fluttere: wasmIssues related to the wasm build of Flutter Web.p: web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions