-
Notifications
You must be signed in to change notification settings - Fork 29.4k
Open
flutter/packages
#10236Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: wasmIssues related to the wasm build of Flutter Web.Issues related to the wasm build of Flutter Web.p: web_benchmarksflutter/packages web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
Now that the skwasm and canvaskit renderers emit the same frame events (see #175392), the expectedBenchmarkMetrics
method here [1] no longer returns the expected events. They are now be the same for both skwasm and canvaskit.
To handle this, I suggest making useWasm
an optional named parameter instead of required.
(Note: This was noticed because the DevTools benchmark tests to began failing, see flutter/devtools#9456)
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: wasmIssues related to the wasm build of Flutter Web.Issues related to the wasm build of Flutter Web.p: web_benchmarksflutter/packages web_benchmarksflutter/packages web_benchmarkspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team