Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Parameter fileName doesn't apply to downloaded files #891

Closed
united3 opened this issue Sep 18, 2023 · 1 comment · Fixed by #893
Closed

iOS: Parameter fileName doesn't apply to downloaded files #891

united3 opened this issue Sep 18, 2023 · 1 comment · Fixed by #893
Labels
bug Something isn't working

Comments

@united3
Copy link

united3 commented Sep 18, 2023

Description:

In version 1.11.2, the fileName parameter is no longer being considered in the enqueue method.
As a result, the final file name is derived from the URL instead of using the specified fileName.

The issue is likely rooted in this method:
https://github.com/fluttercommunity/flutter_downloader/pull/887/files#diff-4f15491f7711a4fcbcc449dbf58ed7a1bf3fbce26a29ff0ff75840f4454b1e0fL346

Xcode even issues a warning regarding the unused fileName variable.

This problem does not exist in version 1.11.1.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.4, on macOS 12.6 21G115 darwin-arm64)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] Network resources
@united3 united3 added the bug Something isn't working label Sep 18, 2023
@salmaahhmed
Copy link
Collaborator

Hello @united3 this was for the security update. the file name imposes a vulnerability. i can check if there's a workaround

@united3 united3 changed the title iOS: Parameter fileName not applies to downloaded files iOS: Parameter fileName don't applies to downloaded files Sep 18, 2023
@united3 united3 changed the title iOS: Parameter fileName don't applies to downloaded files iOS: Parameter fileName doesn't apply to downloaded files Sep 18, 2023
@salmaahhmed salmaahhmed linked a pull request Sep 20, 2023 that will close this issue
fix file name not showing correctly #893
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix file name not showing correctly fluttercommunity/flutter_downloader
2 participants
@united3 @salmaahhmed