From 6c6c65607f585032a01be04aa5bf171d9802956d Mon Sep 17 00:00:00 2001 From: Florian Parga Date: Thu, 20 Jul 2023 12:07:28 -0400 Subject: [PATCH] fix regex example in flux notification for helm release promotion Fixed the regex shown in the example for the Alert/Notification used to trigger an helm release promotion GitHub workflow. The example that was there give the following error: > error parsing regexp: missing argument to repetition operator: * Signed-off-by: Florian Parga --- content/en/flux/use-cases/gh-actions-helm-promotion.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en/flux/use-cases/gh-actions-helm-promotion.md b/content/en/flux/use-cases/gh-actions-helm-promotion.md index 3183239fe..3386dbee3 100644 --- a/content/en/flux/use-cases/gh-actions-helm-promotion.md +++ b/content/en/flux/use-cases/gh-actions-helm-promotion.md @@ -192,13 +192,13 @@ spec: - kind: HelmRelease name: demo inclusionList: - - "*.upgrade.*succeeded.*" + - ".*.upgrade.*succeeded.*" ``` **Note** that you should adapt the above definitions to match your GitHub repository address. If [testing is enabled](https://fluxcd.io/flux/components/helm/helmreleases/#configuring-helm-test-actions) -in your HelmRelease, you can use the `"*.test.*succeeded.*"` -expression in the inclusion list instead of `"*.upgrade.*succeeded.*"`. +in your HelmRelease, you can use the `".*.test.*succeeded.*"` +expression in the inclusion list instead of `".*.upgrade.*succeeded.*"`. This will ensure the promotion happens only after tests have been successfully run. You also need to create a Kubernetes secret with a GitHub Personal Access Token