Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty feature gets saved as "undefined" when creating new Scenario #118

Open
martonsagi opened this issue Nov 27, 2022 · 3 comments
Open

Empty feature gets saved as "undefined" when creating new Scenario #118

martonsagi opened this issue Nov 27, 2022 · 3 comments
Assignees
@lvanvugt
Labels
bug Something isn't working needs test defined
Milestone
v1

Comments

@martonsagi
Copy link
Collaborator

martonsagi commented Nov 27, 2022 •
edited
Loading

Describe the bug
Empty feature gets saved as "undefined" when creating new Scenario.
Other realted error message:
"Cannot read properties of undefined" (reading 'procedureName')

To Reproduce
Steps to reproduce the behavior:

  1. Try adding a new scenario for a project without detected features
@martonsagi martonsagi added the bug Something isn't working label Nov 27, 2022
@lvanvugt lvanvugt mentioned this issue Feb 16, 2023
Open
@lvanvugt lvanvugt added this to the v1 milestone Feb 17, 2023
DavidFeldhoff added a commit that referenced this issue Mar 15, 2023
@DavidFeldhoff
make sure that variables aren't undefined. #118
3d74f5c
DavidFeldhoff added a commit that referenced this issue Mar 15, 2023
@DavidFeldhoff
Empty feature gets saved as "undefined" when c reating new Scenario #118
a6807f0
@DavidFeldhoff
Copy link
Collaborator

This is now not happening anymore. @lvanvugt are you going to add tests for it in the Excel file?

@lvanvugt
Copy link
Contributor

@DavidFeldhoff, probably.

@DavidFeldhoff
Copy link
Collaborator

Basically it have been two errors:

  1. Project has no Features so far and we're creating a new scenario, then // [FEATURE] undefined was added which is now not happening anymore.
  2. the test procedure did not have a // [SCENARIO] comment, but we wanted to delete that test procedure. In the UI we're showing then only the testprocedure name, but as on deletion we did not find the // [SCENARIO] comment, we had an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvanvugt lvanvugt

Labels
bug Something isn't working needs test defined
Projects
None yet
Milestone
v1
Development

No branches or pull requests
3 participants
@martonsagi @lvanvugt @DavidFeldhoff