Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(efb): GSX EFB Integration #8225

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

feat(efb): GSX EFB Integration #8225

wants to merge 10 commits into from

Conversation

Lucky38i
Copy link
Member

@Lucky38i Lucky38i commented Sep 22, 2023

Fixes #7894

Currently Shelved

This implementation is currently shelved until it is possible to reliably intercept EXTERNAL_SYSTEM_TOGGLE key events. This key event is necessary to know when GSX is ready to receive a menu choice and thus programatically command GSX to do commands. Both the KeyInteceptor from the Avionics Framework and the Subscriber doesn't intercept K:EXTERNAL_SYSTEM_TOGGLE either. If anyone can find a solution to do this within the extras-host feel free to let me know. However, until the SDK permits a better way for GSX to notify the sim it's ready, there's not much I can do here.

Summary of Changes

This PR provides the following features:

  • Request GSX boarding via the Payload Page
  • Request the Catering Truck via the Services Page
  • Request the Refueling truck via the Services Page
  • Page dedicated to GSX Pushback
  • Request GSX Deboarding via the Payload Page

Possible Features that I may implement

  • Call GPU
  • Support for De-Ice
  • Add GSX tooltips to the toaster container
  • Automated Features?

Screenshots (if necessary)

Videos to come when PR is ready

References

  • Support Provided by Virtuali (GSX Dev) and @Fragtality (Dev of Fenix2Gsx)

Additional context

Discord username (if different from GitHub): lucky38

Testing instructions

I'll populate this when the PR is ready

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

- Pressing payload play now programatically enables GSX Boarding
- TODO fix boarding started variable
- Requesting Catering and Refueling Truck now supported
- Requesting boarding through EFB now supported
- Disabled Services baggage button when GSX Payload Sync Enabled
- Reworked operative window checking so it's now reactive to the external toggle rather than guessing
- Disable aft passenger door
- Set ULDCode for fwd cargo door to AKH according to spec
- prevented rust code from emitting `stop_boarding`
- Moved pushback pages to dedicated folder
- Added option for enabling GSX Pushback
- Page for GSX Pushback (WIP)
@Watsi01
Copy link
Contributor

Watsi01 commented Oct 6, 2023

I assume it's not possible right now to implement the chocks again in conjunction with GSX?
(to be able to release the parking brakes when docked)
:-)

@Fragtality
Copy link
Contributor

The FBW does hot have Chocks?!
Yeah, I would consider that very important for a complete Integration 😉 (If the Chocks can be triggered on/off by L-Var, they can directly be handled by GSX - at least that was the Case in P3D)

- GSX Pushback Page (WIP)
- Fixed some issues with the localization
- Changes GsxMenuStates to strings
- Added temporary helper functions to retrieve GSX Menu and Tooltips
@tracernz tracernz added this to the v0.12.0 milestone Oct 24, 2023
- Migrate event driven logic to extras-host (WIP)
- Created Interceptor for GSX external Toggling (WIP)
- revised how EFB makes a menu choice
- some other stuff
@Lucky38i Lucky38i added Help Wanted Extra attention is needed Won't Fix This will not be worked on. labels Jan 28, 2024
- Both K: events and key inteceptor provide no luck.
- Project is shelved for the time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed Won't Fix This will not be worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSX next feature(s)
5 participants