-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(efb): GSX EFB Integration #8225
Draft
Lucky38i
wants to merge
10
commits into
master
Choose a base branch
from
gsx-menu-disable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pressing payload play now programatically enables GSX Boarding - TODO fix boarding started variable
- Requesting Catering and Refueling Truck now supported - Requesting boarding through EFB now supported - Disabled Services baggage button when GSX Payload Sync Enabled - Reworked operative window checking so it's now reactive to the external toggle rather than guessing - Disable aft passenger door - Set ULDCode for fwd cargo door to AKH according to spec - prevented rust code from emitting `stop_boarding` - Moved pushback pages to dedicated folder - Added option for enabling GSX Pushback - Page for GSX Pushback (WIP)
I assume it's not possible right now to implement the chocks again in conjunction with GSX? |
The FBW does hot have Chocks?! |
- GSX Pushback Page (WIP) - Fixed some issues with the localization - Changes GsxMenuStates to strings - Added temporary helper functions to retrieve GSX Menu and Tooltips
- Migrate event driven logic to extras-host (WIP)
- Created Interceptor for GSX external Toggling (WIP) - revised how EFB makes a menu choice - some other stuff
Lucky38i
added
Help Wanted
Extra attention is needed
Won't Fix
This will not be worked on.
labels
Jan 28, 2024
- Both K: events and key inteceptor provide no luck. - Project is shelved for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7894
Currently Shelved
This implementation is currently shelved until it is possible to reliably intercept
EXTERNAL_SYSTEM_TOGGLE
key events. This key event is necessary to know when GSX is ready to receive a menu choice and thus programatically command GSX to do commands. Both the KeyInteceptor from the Avionics Framework and the Subscriber doesn't interceptK:EXTERNAL_SYSTEM_TOGGLE
either. If anyone can find a solution to do this within the extras-host feel free to let me know. However, until the SDK permits a better way for GSX to notify the sim it's ready, there's not much I can do here.Summary of Changes
This PR provides the following features:
Possible Features that I may implement
Screenshots (if necessary)
Videos to come when PR is ready
References
Additional context
Discord username (if different from GitHub): lucky38
Testing instructions
I'll populate this when the PR is ready
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.