Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wheels and chocks element clash #8226

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

2hwk
Copy link
Member

@2hwk 2hwk commented Sep 23, 2023

Fixes #8223

Summary of Changes

Hotfix for chocks and Cones not overlapping with aft door

image

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Ensure that Chocks/Cones setting is enabled in the EFB Settings > Sim Options
    image
  2. Check that Cone/Chocks elements do not overlap on the EFB Ground Services Page
  3. Disable Chocks/Cones Setting in the EFB settings > Sim Options page
  4. Check that Cone/Chocks elements do not appear on the EFB Ground Services Page

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@alepouna
Copy link
Member

alepouna commented Oct 3, 2023

QA Report

Discord: alepouna
Object of testing:
Tier of Testing : 1
Date : 8226/09/2023

Testing Process:

  • Ensure that Chocks/Cones setting is enabled in the EFB Settings > Sim Options
  • [PASS] Check that Cone/Chocks elements do not overlap on the EFB Ground Services Page
  • Disable Chocks/Cones Setting in the EFB settings > Sim Options page
  • [PASS] Check that Cone/Chocks elements do not appear on the EFB Ground Services Page

Testing Results:
Passed

@2hwk 2hwk merged commit bc03273 into flybywiresim:master Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

Items overlapping on EFB Ground Services page
4 participants