Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteagent] add reserved field in Get Request Payload #6296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Mar 3, 2025

Tracking issue

#3936

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This PR enhances the Flyte agent's protocol buffers by adding a reserved field to the Get Request payload across both Go and Python implementations. The changes update hex constants, restructure message definitions, and adjust descriptor offsets to ensure consistent serialization while maintaining backward compatibility. These modifications prepare the system for future feature expansions without disrupting existing functionality.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Mar 3, 2025

Code Review Agent Run #887a38

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 3afc47e..3afc47e
    • flyteidl/protos/flyteidl/admin/agent.proto
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Collaborator

flyte-bot commented Mar 3, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
New Feature - Add Reserved Field to Get Request Payload

agent.pb.go - Updated generated proto code to add a reserved field in the Get Request Payload and adjusted hex descriptors accordingly.

agent_pb2.py - Adjusted serialized descriptor boundaries in the generated Python code to align with the new reserved field in proto definitions.

agent.proto - Introduced a reserved field in the proto file to support future protocol enhancements.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.82%. Comparing base (001317f) to head (89a6de7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6296   +/-   ##
=======================================
  Coverage   33.82%   33.82%           
=======================================
  Files        1329     1329           
  Lines      147814   147814           
=======================================
  Hits        50000    50000           
  Misses      92972    92972           
  Partials     4842     4842           
Flag Coverage Δ
unittests-datacatalog 48.01% <ø> (ø)
unittests-flyteadmin 50.11% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 58.09% <ø> (ø)
unittests-flyteidl 6.78% <ø> (ø)
unittests-flyteplugins 49.01% <ø> (ø)
unittests-flytepropeller 36.52% <ø> (ø)
unittests-flytestdlib 50.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Mar 3, 2025

Code Review Agent Run #364fc2

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 3afc47e..89a6de7
    • flyteidl/gen/pb-go/flyteidl/admin/agent.pb.go
    • flyteidl/gen/pb_python/flyteidl/admin/agent_pb2.py
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants