-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flyteagent] add reserved field in Get Request Payload #6296
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Code Review Agent Run #887a38Actionable Suggestions - 0Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6296 +/- ##
=======================================
Coverage 33.82% 33.82%
=======================================
Files 1329 1329
Lines 147814 147814
=======================================
Hits 50000 50000
Misses 92972 92972
Partials 4842 4842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #364fc2Actionable Suggestions - 0Review Details
|
Tracking issue
#3936
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR enhances the Flyte agent's protocol buffers by adding a reserved field to the Get Request payload across both Go and Python implementations. The changes update hex constants, restructure message definitions, and adjust descriptor offsets to ensure consistent serialization while maintaining backward compatibility. These modifications prepare the system for future feature expansions without disrupting existing functionality.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2