From 3475ddc41f2ba31d23dd072362be704d7c2470a0 Mon Sep 17 00:00:00 2001 From: "terry.hung" Date: Fri, 8 Nov 2024 00:43:52 +0800 Subject: [PATCH] [Housekeeping] stop support the python3.8 (#2909) * feat: stop support the python3.8 Signed-off-by: terryhung * fix the image hash Signed-off-by: terryhung * update the pyproject.toml Signed-off-by: terryhung * add the python3.9 support back to flytekit-async-fsspec Signed-off-by: terryhung --------- Signed-off-by: terryhung --- .github/workflows/pythonbuild.yml | 4 +--- .github/workflows/pythonpublish.yml | 1 - plugins/README.md | 7 +++---- plugins/flytekit-airflow/setup.py | 3 +-- plugins/flytekit-async-fsspec/setup.py | 3 +-- plugins/flytekit-aws-athena/setup.py | 3 +-- plugins/flytekit-aws-batch/setup.py | 3 +-- plugins/flytekit-bigquery/setup.py | 3 +-- plugins/flytekit-comet-ml/setup.py | 3 +-- plugins/flytekit-dask/setup.py | 3 +-- plugins/flytekit-data-fsspec/setup.py | 3 +-- plugins/flytekit-dbt/setup.py | 3 +-- plugins/flytekit-deck-standard/setup.py | 3 +-- plugins/flytekit-dolt/setup.py | 3 +-- plugins/flytekit-duckdb/setup.py | 4 +--- plugins/flytekit-envd/setup.py | 3 +-- plugins/flytekit-envd/tests/test_image_spec.py | 12 ++++++------ plugins/flytekit-flyteinteractive/README.md | 4 ++-- plugins/flytekit-flyteinteractive/setup.py | 3 +-- plugins/flytekit-greatexpectations/setup.py | 3 +-- plugins/flytekit-hive/setup.py | 3 +-- plugins/flytekit-huggingface/setup.py | 3 +-- plugins/flytekit-inference/setup.py | 3 +-- plugins/flytekit-k8s-pod/setup.py | 3 +-- plugins/flytekit-kf-mpi/setup.py | 4 +--- plugins/flytekit-kf-pytorch/setup.py | 3 +-- plugins/flytekit-kf-tensorflow/setup.py | 3 +-- plugins/flytekit-mlflow/setup.py | 3 +-- plugins/flytekit-mmcloud/setup.py | 3 +-- plugins/flytekit-modin/setup.py | 3 +-- plugins/flytekit-neptune/setup.py | 3 +-- plugins/flytekit-omegaconf/setup.py | 3 +-- plugins/flytekit-onnx-pytorch/setup.py | 3 +-- plugins/flytekit-onnx-scikitlearn/setup.py | 3 +-- plugins/flytekit-onnx-tensorflow/setup.py | 3 +-- .../flytekitplugins/openai/batch/task.py | 1 - plugins/flytekit-openai/setup.py | 3 +-- plugins/flytekit-pandera/setup.py | 3 +-- plugins/flytekit-papermill/setup.py | 3 +-- plugins/flytekit-perian/setup.py | 3 +-- plugins/flytekit-polars/setup.py | 3 +-- plugins/flytekit-pydantic/setup.py | 3 +-- plugins/flytekit-ray/setup.py | 3 +-- plugins/flytekit-snowflake/setup.py | 3 +-- plugins/flytekit-spark/setup.py | 3 +-- plugins/flytekit-sqlalchemy/setup.py | 3 +-- plugins/flytekit-vaex/setup.py | 3 +-- plugins/flytekit-wandb/setup.py | 3 +-- plugins/flytekit-whylogs/setup.py | 3 +-- pyproject.toml | 3 +-- tests/flytekit/unit/cli/pyflyte/imageSpec.yaml | 2 +- .../flytekit/unit/configuration/test_image_config.py | 2 -- .../flytekit/unit/core/image_spec/test_image_spec.py | 8 ++++---- 53 files changed, 61 insertions(+), 114 deletions(-) diff --git a/.github/workflows/pythonbuild.yml b/.github/workflows/pythonbuild.yml index 8230cf22c8..083634f8bb 100644 --- a/.github/workflows/pythonbuild.yml +++ b/.github/workflows/pythonbuild.yml @@ -27,7 +27,7 @@ jobs: - name: Set Python versions for run run: | if [[ ${{ github.event_name }} == "schedule" ]]; then - echo "python_versions=[\"3.8\",\"3.9\",\"3.10\",\"3.11\",\"3.12\"]" >> $GITHUB_ENV + echo "python_versions=[\"3.9\",\"3.10\",\"3.11\",\"3.12\"]" >> $GITHUB_ENV else echo "python_versions=[\"3.9\", \"3.12\"]" >> $GITHUB_ENV fi @@ -363,8 +363,6 @@ jobs: - flytekit-vaex - flytekit-whylogs exclude: - - python-version: 3.8 - plugin-names: "flytekit-aws-sagemaker" - python-version: 3.9 plugin-names: "flytekit-aws-sagemaker" # flytekit-modin depends on ray which does not have a 3.11 wheel yet. diff --git a/.github/workflows/pythonpublish.yml b/.github/workflows/pythonpublish.yml index 2b4ba6c0d1..11f9c8e222 100644 --- a/.github/workflows/pythonpublish.yml +++ b/.github/workflows/pythonpublish.yml @@ -79,7 +79,6 @@ jobs: strategy: matrix: python-version: - - "3.8" - "3.9" - "3.10" - "3.11" diff --git a/plugins/README.md b/plugins/README.md index 3eb4fae30c..acc7eec4d9 100644 --- a/plugins/README.md +++ b/plugins/README.md @@ -24,8 +24,8 @@ All the Flytekit plugins maintained by the core team are added here. It is not n | dbt | `bash pip install flytekitplugins-dbt` | Run dbt within Flyte | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-dbt.svg)](https://pypi.python.org/pypi/flytekitplugins-dbt/) | Flytekit-only | | Huggingface | `bash pip install flytekitplugins-huggingface` | Read & write Hugginface Datasets as Flyte StructuredDatasets | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-huggingface.svg)](https://pypi.python.org/pypi/flytekitplugins-huggingface/) | Flytekit-only | | DuckDB | `bash pip install flytekitplugins-duckdb` | Run analytical workloads with ease using DuckDB | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-duckdb.svg)](https://pypi.python.org/pypi/flytekitplugins-duckdb/) | Flytekit-only | -| ChatGPT | `bash pip install flytekitplugins-openai` | Interact with OpenAI's ChatGPT. | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-openai.svg)](https://pypi.python.org/pypi/flytekitplugins-openai/) | Flytekit-only | -| OpenAI Batch | `bash pip install flytekitplugins-openai` | Submit requests to OpenAI for asynchronous batch processing. | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-openai.svg)](https://pypi.python.org/pypi/flytekitplugins-openai/) | Flytekit-only | +| ChatGPT | `bash pip install flytekitplugins-openai` | Interact with OpenAI's ChatGPT. | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-openai.svg)](https://pypi.python.org/pypi/flytekitplugins-openai/) | Flytekit-only | +| OpenAI Batch | `bash pip install flytekitplugins-openai` | Submit requests to OpenAI for asynchronous batch processing. | [![PyPI version fury.io](https://badge.fury.io/py/flytekitplugins-openai.svg)](https://pypi.python.org/pypi/flytekitplugins-openai/) | Flytekit-only | ## Have a Plugin Idea? 💡 @@ -101,12 +101,11 @@ setup( packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-airflow/setup.py b/plugins/flytekit-airflow/setup.py index 09536d2e90..98d1b38bf1 100644 --- a/plugins/flytekit-airflow/setup.py +++ b/plugins/flytekit-airflow/setup.py @@ -22,12 +22,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-async-fsspec/setup.py b/plugins/flytekit-async-fsspec/setup.py index 141f2b6081..414658365a 100644 --- a/plugins/flytekit-async-fsspec/setup.py +++ b/plugins/flytekit-async-fsspec/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}", f"flytekitplugins.{PLUGIN_NAME}.s3fs"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-aws-athena/setup.py b/plugins/flytekit-aws-athena/setup.py index 5bbf0581d2..769097a528 100644 --- a/plugins/flytekit-aws-athena/setup.py +++ b/plugins/flytekit-aws-athena/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-aws-batch/setup.py b/plugins/flytekit-aws-batch/setup.py index 423e439ba2..10ee1fcb04 100644 --- a/plugins/flytekit-aws-batch/setup.py +++ b/plugins/flytekit-aws-batch/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-bigquery/setup.py b/plugins/flytekit-bigquery/setup.py index 5a22469f03..b0aab31a93 100644 --- a/plugins/flytekit-bigquery/setup.py +++ b/plugins/flytekit-bigquery/setup.py @@ -23,12 +23,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-comet-ml/setup.py b/plugins/flytekit-comet-ml/setup.py index 387b9119e3..e741423df0 100644 --- a/plugins/flytekit-comet-ml/setup.py +++ b/plugins/flytekit-comet-ml/setup.py @@ -20,12 +20,11 @@ packages=[f"flytekitplugins.{MODULE_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-dask/setup.py b/plugins/flytekit-dask/setup.py index 440d7b47db..bfd56bc2f1 100644 --- a/plugins/flytekit-dask/setup.py +++ b/plugins/flytekit-dask/setup.py @@ -25,12 +25,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", # dask requires >= 3.8 + python_requires=">=3.9", # dask requires >= 3.9 classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-data-fsspec/setup.py b/plugins/flytekit-data-fsspec/setup.py index 0ceae3ac1b..ce19cdd26e 100644 --- a/plugins/flytekit-data-fsspec/setup.py +++ b/plugins/flytekit-data-fsspec/setup.py @@ -27,12 +27,11 @@ "gcp": [], }, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-dbt/setup.py b/plugins/flytekit-dbt/setup.py index aca9ddd6a7..08899d42ce 100644 --- a/plugins/flytekit-dbt/setup.py +++ b/plugins/flytekit-dbt/setup.py @@ -24,12 +24,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-deck-standard/setup.py b/plugins/flytekit-deck-standard/setup.py index 9213b5a533..adfe422bc9 100644 --- a/plugins/flytekit-deck-standard/setup.py +++ b/plugins/flytekit-deck-standard/setup.py @@ -32,12 +32,11 @@ install_requires=plugin_requires, extras_require=extras, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-dolt/setup.py b/plugins/flytekit-dolt/setup.py index 623bf5c728..8e615cdd52 100644 --- a/plugins/flytekit-dolt/setup.py +++ b/plugins/flytekit-dolt/setup.py @@ -34,12 +34,11 @@ def run(self): ), cmdclass=dict(develop=PostDevelopCommand), license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-duckdb/setup.py b/plugins/flytekit-duckdb/setup.py index a23aa9657a..b5ed7f8abc 100644 --- a/plugins/flytekit-duckdb/setup.py +++ b/plugins/flytekit-duckdb/setup.py @@ -18,13 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.7,<3.13", + python_requires=">=3.9,<3.13", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.7", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-envd/setup.py b/plugins/flytekit-envd/setup.py index 43d3712b9b..369f5f8290 100644 --- a/plugins/flytekit-envd/setup.py +++ b/plugins/flytekit-envd/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-envd/tests/test_image_spec.py b/plugins/flytekit-envd/tests/test_image_spec.py index 702da6baf6..e7b87cc1cc 100644 --- a/plugins/flytekit-envd/tests/test_image_spec.py +++ b/plugins/flytekit-envd/tests/test_image_spec.py @@ -24,13 +24,13 @@ def register_envd_higher_priority(): def test_image_spec(): base_image = ImageSpec( packages=["numpy"], - python_version="3.8", + python_version="3.9", registry="", - base_image="cr.flyte.org/flyteorg/flytekit:py3.8-latest", + base_image="cr.flyte.org/flyteorg/flytekit:py3.9-latest", ) # Replace the base image name with the default flytekit image name, # so Envd can find the base image when building imageSpec below - ImageBuildEngine._IMAGE_NAME_TO_REAL_NAME[base_image.image_name()] = "cr.flyte.org/flyteorg/flytekit:py3.8-latest" + ImageBuildEngine._IMAGE_NAME_TO_REAL_NAME[base_image.image_name()] = "cr.flyte.org/flyteorg/flytekit:py3.9-latest" with tempfile.TemporaryDirectory(dir=Path.cwd().as_posix()) as temp_dir: copy_file = Path(temp_dir) / "copy_file.txt" @@ -39,7 +39,7 @@ def test_image_spec(): image_spec = ImageSpec( packages=["pandas"], apt_packages=["git"], - python_version="3.8", + python_version="3.9", base_image=base_image, pip_index="https://pypi.python.org/simple", source_root=os.path.dirname(os.path.realpath(__file__)), @@ -57,13 +57,13 @@ def test_image_spec(): == f"""# syntax=v1 def build(): - base(image="cr.flyte.org/flyteorg/flytekit:py3.8-latest", dev=False) + base(image="cr.flyte.org/flyteorg/flytekit:py3.9-latest", dev=False) run(commands=["echo hello"]) install.python_packages(name=["pandas"]) install.apt_packages(name=["git"]) runtime.environ(env={{'PYTHONPATH': '/root:', '_F_IMG_ID': '{image_spec.id}'}}, extra_path=['/root']) config.pip_index(url="https://pypi.python.org/simple") - install.python(version="3.8") + install.python(version="3.9") io.copy(source="./", target="/root") io.copy(source="{copy_file.relative_to(Path.cwd()).as_posix()}", target="/root/{copy_file.parent.relative_to(Path.cwd()).as_posix()}/") """ diff --git a/plugins/flytekit-flyteinteractive/README.md b/plugins/flytekit-flyteinteractive/README.md index 6c2bd76794..8e9f26de6b 100644 --- a/plugins/flytekit-flyteinteractive/README.md +++ b/plugins/flytekit-flyteinteractive/README.md @@ -29,7 +29,7 @@ def train(): ``` ## User Guide -1. Build the image with Dockerfile.dev `docker buildx build --push . -f Dockerfile.dev -t localhost:30000/flytekit:dev --build-arg PYTHON_VERSION=3.8` +1. Build the image with Dockerfile.dev `docker buildx build --push . -f Dockerfile.dev -t localhost:30000/flytekit:dev --build-arg PYTHON_VERSION=3.9` 2. Run the decorated task on the remote. For example: `pyflyte run --remote --image localhost:30000/flytekit:dev [PYTHONFILE] [WORKFLOW|TASK] [ARGS]...` 3. Once the code server is prepared, you can forward a local port to the pod. For example: `kubectl port-forward -n [NAMESPACE] [PODNAME] 8080:8080`. 4. You can access the server by opening a web browser and navigating to `localhost:8080`. @@ -120,7 +120,7 @@ def train(): ``` ## User Guide -1. Build the image with Dockerfile.dev `docker buildx build --push . -f Dockerfile.dev -t localhost:30000/flytekit:dev --build-arg PYTHON_VERSION=3.8` +1. Build the image with Dockerfile.dev `docker buildx build --push . -f Dockerfile.dev -t localhost:30000/flytekit:dev --build-arg PYTHON_VERSION=3.9` 2. Run the decorated task on the remote. For example: `pyflyte run --remote --image localhost:30000/flytekit:dev [PYTHONFILE] [WORKFLOW|TASK] [ARGS]...` 3. Once the code server is prepared, you can forward a local port to the pod. For example: `kubectl port-forward -n [NAMESPACE] [PODNAME] 8888:8888`. 4. You can access the server by opening a web browser and navigating to `localhost:8888`. diff --git a/plugins/flytekit-flyteinteractive/setup.py b/plugins/flytekit-flyteinteractive/setup.py index 3ca87c9516..a3daa72a7d 100644 --- a/plugins/flytekit-flyteinteractive/setup.py +++ b/plugins/flytekit-flyteinteractive/setup.py @@ -22,12 +22,11 @@ ], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-greatexpectations/setup.py b/plugins/flytekit-greatexpectations/setup.py index bba579442b..bac34912e0 100644 --- a/plugins/flytekit-greatexpectations/setup.py +++ b/plugins/flytekit-greatexpectations/setup.py @@ -24,12 +24,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-hive/setup.py b/plugins/flytekit-hive/setup.py index 3df4213f16..4d906b2fe1 100644 --- a/plugins/flytekit-hive/setup.py +++ b/plugins/flytekit-hive/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-huggingface/setup.py b/plugins/flytekit-huggingface/setup.py index 2c35e02ba3..ff69848e5a 100644 --- a/plugins/flytekit-huggingface/setup.py +++ b/plugins/flytekit-huggingface/setup.py @@ -20,12 +20,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-inference/setup.py b/plugins/flytekit-inference/setup.py index fbc00b43e4..c0f42a2e41 100644 --- a/plugins/flytekit-inference/setup.py +++ b/plugins/flytekit-inference/setup.py @@ -22,12 +22,11 @@ ], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-k8s-pod/setup.py b/plugins/flytekit-k8s-pod/setup.py index 1a3479805b..bb8cac1022 100644 --- a/plugins/flytekit-k8s-pod/setup.py +++ b/plugins/flytekit-k8s-pod/setup.py @@ -21,12 +21,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-kf-mpi/setup.py b/plugins/flytekit-kf-mpi/setup.py index 05efff84b0..77d7038cf9 100644 --- a/plugins/flytekit-kf-mpi/setup.py +++ b/plugins/flytekit-kf-mpi/setup.py @@ -18,13 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.7", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-kf-pytorch/setup.py b/plugins/flytekit-kf-pytorch/setup.py index 317ca7b8a0..e7e26d60c9 100644 --- a/plugins/flytekit-kf-pytorch/setup.py +++ b/plugins/flytekit-kf-pytorch/setup.py @@ -21,12 +21,11 @@ "elastic": ["torch>=1.9.0"], }, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-kf-tensorflow/setup.py b/plugins/flytekit-kf-tensorflow/setup.py index 25ffe19eec..3546961a2a 100644 --- a/plugins/flytekit-kf-tensorflow/setup.py +++ b/plugins/flytekit-kf-tensorflow/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-mlflow/setup.py b/plugins/flytekit-mlflow/setup.py index 8074f4ed06..c3d42d5aa9 100644 --- a/plugins/flytekit-mlflow/setup.py +++ b/plugins/flytekit-mlflow/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-mmcloud/setup.py b/plugins/flytekit-mmcloud/setup.py index 62ae9c0328..eb17f1e103 100644 --- a/plugins/flytekit-mmcloud/setup.py +++ b/plugins/flytekit-mmcloud/setup.py @@ -20,12 +20,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-modin/setup.py b/plugins/flytekit-modin/setup.py index 151b4a4c9f..d78b4f49d6 100644 --- a/plugins/flytekit-modin/setup.py +++ b/plugins/flytekit-modin/setup.py @@ -20,12 +20,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-neptune/setup.py b/plugins/flytekit-neptune/setup.py index 3ef3fda094..d48fc71eac 100644 --- a/plugins/flytekit-neptune/setup.py +++ b/plugins/flytekit-neptune/setup.py @@ -19,12 +19,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-omegaconf/setup.py b/plugins/flytekit-omegaconf/setup.py index 3f57594a15..1c5563dd92 100644 --- a/plugins/flytekit-omegaconf/setup.py +++ b/plugins/flytekit-omegaconf/setup.py @@ -21,12 +21,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-onnx-pytorch/setup.py b/plugins/flytekit-onnx-pytorch/setup.py index 6a202ff504..5c2fa9cb30 100644 --- a/plugins/flytekit-onnx-pytorch/setup.py +++ b/plugins/flytekit-onnx-pytorch/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-onnx-scikitlearn/setup.py b/plugins/flytekit-onnx-scikitlearn/setup.py index fe55536066..0772861f99 100644 --- a/plugins/flytekit-onnx-scikitlearn/setup.py +++ b/plugins/flytekit-onnx-scikitlearn/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-onnx-tensorflow/setup.py b/plugins/flytekit-onnx-tensorflow/setup.py index 11ea2afb41..ad3d81d707 100644 --- a/plugins/flytekit-onnx-tensorflow/setup.py +++ b/plugins/flytekit-onnx-tensorflow/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-openai/flytekitplugins/openai/batch/task.py b/plugins/flytekit-openai/flytekitplugins/openai/batch/task.py index 7bac8c7171..b5b1c3c4e4 100644 --- a/plugins/flytekit-openai/flytekitplugins/openai/batch/task.py +++ b/plugins/flytekit-openai/flytekitplugins/openai/batch/task.py @@ -60,7 +60,6 @@ class OpenAIFileDefaultImages(DefaultImages): """Default images for the openai batch plugin.""" _DEFAULT_IMAGE_PREFIXES = { - PythonVersion.PYTHON_3_8: "cr.flyte.org/flyteorg/flytekit:py3.8-openai-batch-", PythonVersion.PYTHON_3_9: "cr.flyte.org/flyteorg/flytekit:py3.9-openai-batch-", PythonVersion.PYTHON_3_10: "cr.flyte.org/flyteorg/flytekit:py3.10-openai-batch-", PythonVersion.PYTHON_3_11: "cr.flyte.org/flyteorg/flytekit:py3.11-openai-batch-", diff --git a/plugins/flytekit-openai/setup.py b/plugins/flytekit-openai/setup.py index 07db38c212..457dcb6861 100644 --- a/plugins/flytekit-openai/setup.py +++ b/plugins/flytekit-openai/setup.py @@ -22,12 +22,11 @@ ], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-pandera/setup.py b/plugins/flytekit-pandera/setup.py index 5e0c9bf8ff..c4c0b8161f 100644 --- a/plugins/flytekit-pandera/setup.py +++ b/plugins/flytekit-pandera/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-papermill/setup.py b/plugins/flytekit-papermill/setup.py index 538946a6d7..6c0c949f33 100644 --- a/plugins/flytekit-papermill/setup.py +++ b/plugins/flytekit-papermill/setup.py @@ -23,12 +23,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-perian/setup.py b/plugins/flytekit-perian/setup.py index 86ab4056c4..f647a9049d 100644 --- a/plugins/flytekit-perian/setup.py +++ b/plugins/flytekit-perian/setup.py @@ -20,12 +20,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-polars/setup.py b/plugins/flytekit-polars/setup.py index d1a2372eff..7780c1680b 100644 --- a/plugins/flytekit-polars/setup.py +++ b/plugins/flytekit-polars/setup.py @@ -17,12 +17,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-pydantic/setup.py b/plugins/flytekit-pydantic/setup.py index 7001506a70..4ff6d15529 100644 --- a/plugins/flytekit-pydantic/setup.py +++ b/plugins/flytekit-pydantic/setup.py @@ -21,12 +21,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-ray/setup.py b/plugins/flytekit-ray/setup.py index 2a6edc130b..24ac718170 100644 --- a/plugins/flytekit-ray/setup.py +++ b/plugins/flytekit-ray/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-snowflake/setup.py b/plugins/flytekit-snowflake/setup.py index ec1d6e0158..154f67cf33 100644 --- a/plugins/flytekit-snowflake/setup.py +++ b/plugins/flytekit-snowflake/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-spark/setup.py b/plugins/flytekit-spark/setup.py index 6218496050..57138ae773 100644 --- a/plugins/flytekit-spark/setup.py +++ b/plugins/flytekit-spark/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-sqlalchemy/setup.py b/plugins/flytekit-sqlalchemy/setup.py index 4d59e31686..650f99b6fd 100644 --- a/plugins/flytekit-sqlalchemy/setup.py +++ b/plugins/flytekit-sqlalchemy/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-vaex/setup.py b/plugins/flytekit-vaex/setup.py index fb464514cb..5fb22cfc2d 100644 --- a/plugins/flytekit-vaex/setup.py +++ b/plugins/flytekit-vaex/setup.py @@ -24,12 +24,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/plugins/flytekit-wandb/setup.py b/plugins/flytekit-wandb/setup.py index 1de49670f4..adb9fb3da1 100644 --- a/plugins/flytekit-wandb/setup.py +++ b/plugins/flytekit-wandb/setup.py @@ -18,12 +18,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/plugins/flytekit-whylogs/setup.py b/plugins/flytekit-whylogs/setup.py index ed9964ed4f..2ab318b08b 100644 --- a/plugins/flytekit-whylogs/setup.py +++ b/plugins/flytekit-whylogs/setup.py @@ -21,12 +21,11 @@ packages=[f"flytekitplugins.{PLUGIN_NAME}"], install_requires=plugin_requires, license="apache2", - python_requires=">=3.8", + python_requires=">=3.9", classifiers=[ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Topic :: Scientific/Engineering", diff --git a/pyproject.toml b/pyproject.toml index fa370e8970..88df9feb4c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -9,7 +9,7 @@ authors = [{ name = "Flyte Contributors", email = "admin@flyte.org" }] description = "Flyte SDK for Python" license = { text = "Apache-2.0" } readme = { file = "README.md", content-type = "text/markdown" } -requires-python = ">=3.8,<3.13" +requires-python = ">=3.9,<3.13" dependencies = [ # Please maintain an alphabetical order in the following list "adlfs>=2023.3.0", @@ -53,7 +53,6 @@ classifiers = [ "Intended Audience :: Science/Research", "Intended Audience :: Developers", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", diff --git a/tests/flytekit/unit/cli/pyflyte/imageSpec.yaml b/tests/flytekit/unit/cli/pyflyte/imageSpec.yaml index ba67ab4b91..f2dbca2d22 100644 --- a/tests/flytekit/unit/cli/pyflyte/imageSpec.yaml +++ b/tests/flytekit/unit/cli/pyflyte/imageSpec.yaml @@ -1,2 +1,2 @@ -python_version: 3.8 +python_version: 3.9 builder: test diff --git a/tests/flytekit/unit/configuration/test_image_config.py b/tests/flytekit/unit/configuration/test_image_config.py index 8ae3b2d6fd..c1e68be11a 100644 --- a/tests/flytekit/unit/configuration/test_image_config.py +++ b/tests/flytekit/unit/configuration/test_image_config.py @@ -14,7 +14,6 @@ @pytest.mark.parametrize( "python_version_enum, expected_image_string", [ - (PythonVersion.PYTHON_3_8, "cr.flyte.org/flyteorg/flytekit:py3.8-latest"), (PythonVersion.PYTHON_3_9, "cr.flyte.org/flyteorg/flytekit:py3.9-latest"), (PythonVersion.PYTHON_3_10, "cr.flyte.org/flyteorg/flytekit:py3.10-latest"), ], @@ -27,7 +26,6 @@ def test_defaults(python_version_enum, expected_image_string): "python_version_enum, flytekit_version, expected_image_string", [ (PythonVersion.PYTHON_3_9, "v0.32.0", "cr.flyte.org/flyteorg/flytekit:py3.9-0.32.0"), - (PythonVersion.PYTHON_3_8, "1.31.3", "cr.flyte.org/flyteorg/flytekit:py3.8-1.31.3"), ], ) def test_set_both(python_version_enum, flytekit_version, expected_image_string): diff --git a/tests/flytekit/unit/core/image_spec/test_image_spec.py b/tests/flytekit/unit/core/image_spec/test_image_spec.py index 7f3de9622d..b20030c3a0 100644 --- a/tests/flytekit/unit/core/image_spec/test_image_spec.py +++ b/tests/flytekit/unit/core/image_spec/test_image_spec.py @@ -7,7 +7,7 @@ from flytekit.core import context_manager from flytekit.core.context_manager import ExecutionState from flytekit.image_spec import ImageSpec -from flytekit.image_spec.image_spec import _F_IMG_ID, ImageBuildEngine, FLYTE_FORCE_PUSH_IMAGE_SPEC +from flytekit.image_spec.image_spec import _F_IMG_ID, ImageBuildEngine from flytekit.core.python_auto_container import update_image_spec_copy_handling from flytekit.configuration import SerializationSettings, FastSerializationSettings, ImageConfig from flytekit.constants import CopyFileDetection @@ -24,7 +24,7 @@ def test_image_spec(mock_image_spec_builder, monkeypatch): builder="dummy", packages=["pandas"], apt_packages=["git"], - python_version="3.8", + python_version="3.9", registry="localhost:30001", base_image=base_image, cuda="11.2.2", @@ -42,7 +42,7 @@ def test_image_spec(mock_image_spec_builder, monkeypatch): image_spec = image_spec.with_copy(["/src", "/src/file2.txt"]) image_spec = image_spec.force_push() - assert image_spec.python_version == "3.8" + assert image_spec.python_version == "3.9" assert image_spec.base_image == base_image assert image_spec.packages == ["pandas", "numpy"] assert image_spec.apt_packages == ["git", "wget"] @@ -62,7 +62,7 @@ def test_image_spec(mock_image_spec_builder, monkeypatch): assert image_spec.entrypoint == ["/bin/bash"] assert image_spec.copy == ["/src/file1.txt", "/src", "/src/file2.txt"] - assert image_spec.image_name() == f"localhost:30001/flytekit:fYU5EUF6y0b2oFG4tu70tA" + assert image_spec.image_name() == f"localhost:30001/flytekit:AjLtng9gJfYzLnjbNy70gA" ctx = context_manager.FlyteContext.current_context() with context_manager.FlyteContextManager.with_context( ctx.with_execution_state(ctx.execution_state.with_params(mode=ExecutionState.Mode.TASK_EXECUTION))