Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slam_toolbox parameter renamed! #30

Open
2 of 4 tasks
dgarcu opened this issue Apr 4, 2024 · 1 comment
Open
2 of 4 tasks

slam_toolbox parameter renamed! #30

dgarcu opened this issue Apr 4, 2024 · 1 comment

Comments

@dgarcu
Copy link

dgarcu commented Apr 4, 2024

Important!!!

  • I have checked that this issue/bug/fix/correction has not been already created before in open or closed issues.

Type of bug

  • A) Typo/error in Figure/text
  • B) Bug in code
  • C) General comment, recommendation or petition

Issue Description

A parameter from https://github.com/SteveMacenski/slam_toolbox online async launcher has been renamed in this PR: SteveMacenski/slam_toolbox#363

More details: ros-navigation/navigation2#2240

Typo/Error Description

In the slides, chapter 6, slide 59/62:

ros2 launch slam_toolbox online_async_launch.py params_file:=[File path] use_sim_time:=true

From mentioned PR onwards, this should be:

ros2 launch slam_toolbox online_async_launch.py slam_params_file:=[File path] use_sim_time:=true

Proposal

I am aware of a new edition of the book being written, so I understand this has been updated already. However the docs from this very repo are outdated in that regard, so maybe leave this issue open until the docs are updated. 😃

Desktop:

  • OS: distro
  • ROS2 Distro: distro
@fmrico
Copy link
Owner

fmrico commented Apr 4, 2024

Thanks @dgarcu

I will maintain open this issue until it is fixed in the Second Edition.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants