From 6abf5e3f680f38d12ec1c2d6439e621ec6495b21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Mart=C3=ADn=20Rico?= Date: Fri, 15 Mar 2024 05:45:08 +0100 Subject: [PATCH 1/3] Fix clear_activation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Francisco Martín Rico --- .../src/rclcpp_cascade_lifecycle/rclcpp_cascade_lifecycle.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rclcpp_cascade_lifecycle/src/rclcpp_cascade_lifecycle/rclcpp_cascade_lifecycle.cpp b/rclcpp_cascade_lifecycle/src/rclcpp_cascade_lifecycle/rclcpp_cascade_lifecycle.cpp index e34b6e8..aa7154b 100644 --- a/rclcpp_cascade_lifecycle/src/rclcpp_cascade_lifecycle/rclcpp_cascade_lifecycle.cpp +++ b/rclcpp_cascade_lifecycle/src/rclcpp_cascade_lifecycle/rclcpp_cascade_lifecycle.cpp @@ -202,8 +202,8 @@ CascadeLifecycleNode::remove_activation(const std::string & node_name) void CascadeLifecycleNode::clear_activation() { - for (const auto & activation : activations_) { - remove_activation(activation); + while (!activations_.empty()) { + remove_activation(*activations_.begin()); } } From 6a064de3abce8378a3a7462f94068f7ab72b01f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Mart=C3=ADn=20Rico?= Date: Fri, 15 Mar 2024 05:52:32 +0100 Subject: [PATCH 2/3] Update CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Francisco Martín Rico --- .github/workflows/humble-devel.yaml | 4 ++-- .github/workflows/rolling-devel.yaml | 6 +++--- .github/workflows/rolling.yaml | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/humble-devel.yaml b/.github/workflows/humble-devel.yaml index 3984251..35ed625 100644 --- a/.github/workflows/humble-devel.yaml +++ b/.github/workflows/humble-devel.yaml @@ -17,11 +17,11 @@ jobs: fail-fast: false steps: - name: Setup ROS 2 - uses: ros-tooling/setup-ros@0.3.3 + uses: ros-tooling/setup-ros@0.7.1 with: required-ros-distributions: humble - name: build and test - uses: ros-tooling/action-ros-ci@0.2.5 + uses: ros-tooling/action-ros-ci@0.3.6 with: package-name: rclcpp_cascade_lifecycle cascade_lifecycle_msgs target-ros2-distro: humble diff --git a/.github/workflows/rolling-devel.yaml b/.github/workflows/rolling-devel.yaml index b9abe3f..1de46da 100644 --- a/.github/workflows/rolling-devel.yaml +++ b/.github/workflows/rolling-devel.yaml @@ -20,11 +20,11 @@ jobs: fail-fast: false steps: - name: Setup ROS 2 - uses: ros-tooling/setup-ros@0.4.1 + uses: ros-tooling/setup-ros@0.7.1 with: - required-ros-distributions: rolling + required-ros-distributions: humble - name: build and test - uses: ros-tooling/action-ros-ci@0.2.7 + uses: ros-tooling/action-ros-ci@0.3.6 with: package-name: rclcpp_cascade_lifecycle cascade_lifecycle_msgs target-ros2-distro: rolling diff --git a/.github/workflows/rolling.yaml b/.github/workflows/rolling.yaml index abf2ae2..911e40e 100644 --- a/.github/workflows/rolling.yaml +++ b/.github/workflows/rolling.yaml @@ -20,11 +20,11 @@ jobs: fail-fast: false steps: - name: Setup ROS 2 - uses: ros-tooling/setup-ros@0.4.1 + uses: ros-tooling/setup-ros@0.7.1 with: - required-ros-distributions: rolling + required-ros-distributions: humble - name: build and test - uses: ros-tooling/action-ros-ci@0.2.7 + uses: ros-tooling/action-ros-ci@0.3.6 with: package-name: rclcpp_cascade_lifecycle cascade_lifecycle_msgs target-ros2-distro: rolling From 3e59b55813bbcf2e6ef7f94d4db6b2ea93d1432d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Mart=C3=ADn=20Rico?= Date: Fri, 15 Mar 2024 06:13:20 +0100 Subject: [PATCH 3/3] update CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Francisco Martín Rico --- .github/workflows/rolling.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rolling.yaml b/.github/workflows/rolling.yaml index 911e40e..7b2811c 100644 --- a/.github/workflows/rolling.yaml +++ b/.github/workflows/rolling.yaml @@ -22,7 +22,7 @@ jobs: - name: Setup ROS 2 uses: ros-tooling/setup-ros@0.7.1 with: - required-ros-distributions: humble + required-ros-distributions: rolling - name: build and test uses: ros-tooling/action-ros-ci@0.3.6 with: