Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong order of parameters in createRoot #33

Closed
AyronK opened this issue Nov 23, 2023 · 1 comment · Fixed by #31
Closed

Wrong order of parameters in createRoot #33

AyronK opened this issue Nov 23, 2023 · 1 comment · Fixed by #31
Assignees
@AyronK
Labels
bug Something isn't working

Comments

@AyronK
Copy link
Collaborator

AyronK commented Nov 23, 2023

Optional parameters should be passed to render, not createRoot itself.
@AyronK AyronK added the bug Something isn't working label Nov 23, 2023
@AyronK AyronK mentioned this issue Nov 23, 2023
Merged
@AyronK AyronK self-assigned this Nov 23, 2023
AyronK added a commit that referenced this issue Nov 24, 2023
@AyronK
Fixed identifier prefix support and added an optional setting to swit…
1b0020b 
…ch it on

# Added
- #34
- Documentation annotations for `ReactConfiguration`

# Fixed
- #32
- #33
- Code references in Demo project

* Added switch for identifier prefix and added support in renderToPipeableStream.

* Fixed .net core example

* Updated version and nuget packages

* Fixed hydration condition based on options

* Optional prefix identifier in RenderAsync

* Moved upgraded nuget to proper section
@AyronK AyronK closed this as completed Nov 27, 2023
@AyronK
Copy link
Collaborator Author

AyronK commented Nov 27, 2023

#31

@AyronK AyronK linked a pull request Nov 27, 2023 that will close this issue
Fixed identifier prefix support and added an optional setting to switch it on #31
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AyronK AyronK

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@AyronK